Bug 435255 - [Graphics] thread*.png icons look blurry
Summary: [Graphics] thread*.png icons look blurry
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Tony McCrary CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, greatfix
Depends on:
Blocks:
 
Reported: 2014-05-20 04:47 EDT by Dani Megert CLA
Modified: 2015-04-27 06:45 EDT (History)
4 users (show)

See Also:


Attachments
Picture with thread icons (81.16 KB, image/png)
2014-05-20 04:58 EDT, Dani Megert CLA
no flags Details
updated icons (223.05 KB, image/png)
2015-01-19 19:46 EST, Tony McCrary CLA
no flags Details
comparison gallery feb 4th 2015 (222.52 KB, image/png)
2015-02-04 19:43 EST, Tony McCrary CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2014-05-20 04:47:30 EDT
4.4 RC1.

The thread*.png icons look blurry under Windows 7 and when there's a warning overlay the icons looks strange (like an Olympic flame).

We either need a better version or go back to GIFs.
Comment 1 Dani Megert CLA 2014-05-20 04:52:02 EDT
It attracted my attention due to the "Olympic flame". Looking at 3.8.x with the GIFs, it also doesn't look better.

Would still be good to have the "wheel(s)" a little bit sharper, but this can wait for 4.4.1.
Comment 2 Dani Megert CLA 2014-05-20 04:58:18 EDT
Created attachment 243278 [details]
Picture with thread icons

On the top there's the GIF versions and below the current PNG versions.
Comment 3 Dani Megert CLA 2014-05-20 05:01:19 EDT
(In reply to Dani Megert from comment #0)
> We either need a better version or go back to GIFs.

I take that back for 4.4.
Comment 4 Lars Vogel CLA 2014-11-28 15:06:09 EST
(In reply to Dani Megert from comment #2)
> Created attachment 243278 [details]
> Picture with thread icons
> 
> On the top there's the GIF versions and below the current PNG versions.

Tony, could you update the related icons?
Comment 5 Sarika Sinha CLA 2015-01-14 03:57:08 EST
Are we getting this in 4.5 M5 ?
Comment 6 Tony McCrary CLA 2015-01-19 19:46:21 EST
Created attachment 250058 [details]
updated icons

I've updated the debug gear icon along with other minor fixes. Please review this gallery and let me know if the gear is fixed. On the two icon columns left is gif, right is svg rendered into png.

Some of the icons that have non squared sizes are a little off in the gallery.
Comment 7 Sarika Sinha CLA 2015-01-20 06:40:28 EST
(In reply to Tony McCrary from comment #6)
> Created attachment 250058 [details]
> updated icons
> 
> I've updated the debug gear icon along with other minor fixes. Please review
> this gallery and let me know if the gear is fixed. On the two icon columns
> left is gif, right is svg rendered into png.
> 
> Some of the icons that have non squared sizes are a little off in the
> gallery.


Gear looks good now. But two objects does not look ok. memorychanged_obj looks very different and lock_co looks less sharper.
Comment 8 Tony McCrary CLA 2015-01-20 08:09:31 EST
the memorychanged icon is not square (it looks okay in Eclipse, I believe it's already been used for luna).

I noticed the lock as well, it's just too detailed for low res usage so I'll need to recreate a simpler version.

I will get that updated along with a commit of the new icon resources.
Comment 9 Lars Vogel CLA 2015-01-22 06:15:46 EST
(In reply to Tony McCrary from comment #8) 
> I will get that updated along with a commit of the new icon resources.

Tony, once you updated the icons, can you also upload a new comparison image of them?
Comment 10 Tony McCrary CLA 2015-02-04 19:43:41 EST
Created attachment 250511 [details]
comparison gallery feb 4th 2015

Here is an updated gallery.
Comment 11 Sarika Sinha CLA 2015-02-05 04:09:00 EST
Lock looks good now !!
Comment 12 Lars Vogel CLA 2015-02-05 04:16:31 EST
(In reply to Sarika Sinha from comment #11)
> Lock looks good now !!

Great to hear. 

@Tony, can you push them to the to image repo via Gerrit? Do you want me to integrate them into Debug via Gerrit or do you prefer to do it directly?
Comment 13 Sarika Sinha CLA 2015-03-16 04:57:24 EDT
Are we pushing it in M6 ?
Comment 14 Sarika Sinha CLA 2015-03-17 07:41:47 EDT
Moving it to M7.
Comment 15 Eclipse Genie CLA 2015-03-24 23:09:23 EDT
New Gerrit change created: https://git.eclipse.org/r/44549
Comment 16 Lars Vogel CLA 2015-03-24 23:11:48 EDT
(In reply to Eclipse Genie from comment #15)
> New Gerrit change created: https://git.eclipse.org/r/44549

Tony provided improved icons, please have a look at the Gerrit change.
Comment 17 Sarika Sinha CLA 2015-03-25 07:10:29 EDT
Gerrit has Thread related png files, I thought we will get a new lock_co.png also ?
Comment 18 Lars Vogel CLA 2015-03-30 06:42:16 EDT
(In reply to Sarika Sinha from comment #17)
> Gerrit has Thread related png files, I thought we will get a new lock_co.png
> also ?

I updated the existing Gerrit review with a more crisp version of lock_co.png also. Please review.
Comment 20 Sarika Sinha CLA 2015-03-31 03:04:22 EDT
Thanks Lars and Tony.
Comment 21 Sarika Sinha CLA 2015-04-27 06:45:08 EDT
Verified using
Eclipse SDK

Version: Mars (4.5)
Build id: I20150426-2000