Bug 434932 - Add tests for bug 433061
Summary: Add tests for bug 433061
Status: CLOSED DUPLICATE of bug 435519
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sergey Prigogin CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2014-05-15 04:52 EDT by Szymon Ptaszkiewicz CLA
Modified: 2014-05-22 09:58 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2014-05-15 04:52:57 EDT 
In bug 433061 comment 12 there are two issues mentioned. The first issue is fixed and has a proper test. The second issue is fixed but there is no test for this case and appropriate test needs to be added.
Comment 1 Szymon Ptaszkiewicz CLA 2014-05-21 08:14:12 EDT 
It turned out that test case added for the first issue is not correct because it doesn't test anything, see bug 433061 comment 18. We need to add two separate test cases for both issues that got fixed in bug 433061.
Comment 2 Szymon Ptaszkiewicz CLA 2014-05-21 08:37:41 EDT 
There are at least two separate tests needed: one for the change in LocalFile and one for the change in Workspace.
Comment 3 Sergey Prigogin CLA 2014-05-21 20:19:27 EDT 
The test for the change in Workspace is added in https://git.eclipse.org/r/#/c/27073. The same commit reverts the change in LocalFile since it is unnecessary. The current version of SymlinkTest verifies that LocalFile.delete method preserves contents of the target directory of a deleted symlink.
Comment 4 Szymon Ptaszkiewicz CLA 2014-05-22 09:55:59 EDT 
We will clean up the fix for bug 433061 in bug 435519.

*** This bug has been marked as a duplicate of bug 435519 ***