Bug 434575 - [JFace] Mark TableTreeViewer for deletion
Summary: [JFace] Mark TableTreeViewer for deletion
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: 4.4 RC4   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks: 436505
  Show dependency tree
 
Reported: 2014-05-10 10:03 EDT by Jeanderson Candido CLA
Modified: 2015-09-14 02:57 EDT (History)
4 users (show)

See Also:
daniel_megert: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeanderson Candido CLA 2014-05-10 10:03:19 EDT 
I would like to suggest TableTreeViewer for deletion since it is out-dated (https://bugs.eclipse.org/bugs/show_bug.cgi?id=159550)

In addition, there are other related components from org.eclipse.swt.custom that could be marked for deletion as well:

- org.eclipse.swt.custome.TableTree
- org.eclipse.swt.custome.TableTreeItem
Comment 1 Dani Megert CLA 2014-05-12 06:52:58 EDT 
Lars, can you take this?
Comment 3 Dani Megert CLA 2014-06-03 15:57:59 EDT 
(In reply to Lars Vogel from comment #2)
> Fixed with
> https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/
> ?id=b440cc04d412d83f31d9462927a16959af6e0045

Doesn't that feel much better than Gerrit? :-)
Comment 4 Dani Megert CLA 2014-06-04 16:26:36 EDT 
Put code into code tag instead of italic tag.
Comment 5 Marc-André Laperle CLA 2015-09-13 13:34:56 EDT 
CDT was affected by this change, see bug 477112 and
https://git.eclipse.org/r/#/c/55698/

This was not a difficult change because in was unused code in an internal package.

I feel like this kind change is a bit dangerous in the Platform, in something as widely used as JFace. I think that jface should bump its major version and the best time for that would have been for Eclipse 4.0. But I understand that it's impossible to go back in time now and there is some value in cleaning up some code even before Eclipse 5.0.