Community
Participate
Working Groups
Before start any work related to the proposal for JFace, it would be beneficial to clean up tests from JFace.
I'm working on this issue with Lars Vogel. We are continue the work from #430873. We decided to create this issue to keep it separated from clean up from JFace code.
Refactored tests from FieldAssistAPITests: https://git.eclipse.org/r/25678
Removed warnings from WizardTest: https://git.eclipse.org/r/25679 This class deserve a deeper look later. Large methods with long statements doesn't seems proper and there must be a better way to improve it. By now, just removing annoying warnings from JFace tests.
Removed another warning. Subclass was making an unnecessary override of super-class: https://git.eclipse.org/r/25751
Removed warning related to the use of raw types: https://git.eclipse.org/r/25752
general clean up: https://git.eclipse.org/r/25812
(In reply to Jeanderson Candido from comment #4) > Removed another warning. > Subclass was making an unnecessary override of super-class: > https://git.eclipse.org/r/25751 Thanks. Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f22406ccafdbf9109579c65a8496f46a39906b51
(In reply to Lars Vogel from comment #7) > (In reply to Jeanderson Candido from comment #4) > > Removed another warning. > > Subclass was making an unnecessary override of super-class: > > https://git.eclipse.org/r/25751 > > Thanks. Merged with > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=f22406ccafdbf9109579c65a8496f46a39906b51 TestTableTree is testing deprecated API and TestTree it's just a version of TestTableTree with TreeViewer. I would say that we should believe but in fact it is really testing something that apparently should not exist (it is deprecated). What would be the best option to get rid of the warning caused by this TestTableTree?
Removed warning from fieldassist test: https://git.eclipse.org/r/26307
(In reply to Jeanderson Candido from comment #8) > I would say that we should believe but in > fact it is really testing something that apparently should not exist (it is > deprecated). Deprecated does not mean it is not used anymore, it simply say it should not be used. Please open a bug suggesting to mark TableTree for deletion. If approved, the policy of platform will allow us to delete it in two years. > What would be the best option to get rid of the warning caused by this > TestTableTree? Use Suppress Warning("deprecated")
(In reply to Jeanderson Candido from comment #2) > Refactored tests from FieldAssistAPITests: https://git.eclipse.org/r/25678 Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7cc6bbf25e39de29089d87e8f8f6ed44f70104e6
(In reply to Jeanderson Candido from comment #3) > Removed warnings from WizardTest: https://git.eclipse.org/r/25679 > Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=89b764abca5c5d988ed28723d5ed08890bf55470
(In reply to Jeanderson Candido from comment #6) > general clean up: https://git.eclipse.org/r/25812 Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d1c5d26867bd9a7f7099e4b66479f83885779eb7
GSoC is finished so per definition this bug is closed. Thanks Jeanderson.
(In reply to Lars Vogel from comment #14) > GSoC is finished so per definition this bug is closed. Thanks Jeanderson. Thank you too Lars. There's patch remaining (https://git.eclipse.org/r/#/c/26307/). Just wondering, will it be reviewed? I need to rebase it first.
