Comment 1 Lars Vogel 2014-04-27 16:09:39 EDT

Jeanderson can you work on this? I did a first round, please review and tests this change

https://git.eclipse.org/r/25631

Comment 2 Jeanderson Candido 2014-04-28 00:32:51 EDT

(In reply to Lars Vogel from comment #1)
> Jeanderson can you work on this? I did a first round, please review and
> tests this change
> 
> https://git.eclipse.org/r/25631

I took a look in your review. Despite some mixing with tabs and spaces, everything seems good for me.

I'm just a little confused by the last file:
Before: MockMarkerEntry[] fArray2=(MockMarkerEntry[]) fArray1.clone();
After:  MockMarkerEntry[] fArray2=fArray1.clone();

Is this safe? I'm not sure if there's a class in the class hierarchy overriding the .clone method although the compiler didn't complain about it and tests passed here.

Comment 3 Lars Vogel 2014-04-28 00:47:17 EDT

(In reply to Jeanderson Candido from comment #2)
> (In reply to Lars Vogel from comment #1)
> > Jeanderson can you work on this? I did a first round, please review and
> > tests this change
> > 
> > https://git.eclipse.org/r/25631
> 
> I took a look in your review. Despite some mixing with tabs and spaces,
> everything seems good for me.

Thanks for the review. JDT replaces spaces with tabs, so I think that is ok
> I'm just a little confused by the last file:
> Before: MockMarkerEntry[] fArray2=(MockMarkerEntry[]) fArray1.clone();
> After:  MockMarkerEntry[] fArray2=fArray1.clone();
> 
> Is this safe? I'm not sure if there's a class in the class hierarchy
> overriding the .clone method although the compiler didn't complain about it
> and tests passed here.

I think it is, if the tests are passing, this should be fine. Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0a0d36d5cc5ee25ef2ccf27d6d15756729577640

Comment 4 Jeanderson Candido 2014-04-28 14:05:43 EDT

When I was attempting to clear org.eclipse.ui.tests.adaptable, I found out some dummy methods:

They are called somewhere in the package (usually in another test case) but they actually have no implementation and sometimes ignore parameters). I guess it would be better to postpone these fixes because there are several ways to handle them.

By now, just simple fixes in AdaptableDecoratorTestCase: https://git.eclipse.org/r/25686

Comment 5 Jeanderson Candido 2014-04-28 14:06:09 EDT

When I was attempting to clear org.eclipse.ui.tests.adaptable, I found out some dummy methods:

They are called somewhere in the package (usually in another test case) but they actually have no implementation and sometimes ignore parameters). I guess it would be better to postpone these fixes because there are several ways to handle them.

By now, just simple fixes in AdaptableDecoratorTestCase: https://git.eclipse.org/r/25686

Comment 6 Jeanderson Candido 2014-04-28 14:07:07 EDT

* Ignore the duplicated. Sorry about it.

Comment 7 Jeanderson Candido 2014-04-28 16:23:08 EDT

I did another round of clean ups: https://git.eclipse.org/r/25694

Also, another problem that I notice is the evidence of a past migration but the code wasn't properly cleaned. Some methods have non-javadoc comments, which suggests they were automatically generated, but now they are not defined in a supper class nor interface.

Comment 8 Lars Vogel 2014-05-06 01:01:02 EDT

(In reply to Jeanderson Candido from comment #5)
> 
> By now, just simple fixes in AdaptableDecoratorTestCase:
> https://git.eclipse.org/r/25686

Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4af2f3c889e909d8c044186565992e6b87b5aaa9

Comment 9 Dani Megert 2014-05-21 15:54:49 EDT

I don't want to see such changes in RC4. Please close during RC3.

Comment 10 Lars Vogel 2014-09-10 05:06:05 EDT

Several fixes from Jeanderson: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=342ee93f8b3e519e4faeb1b4e1f5d3099840298e

Comment 11 Aurelien Pupier 2014-12-19 10:37:28 EST

several change for performance test plugin: https://git.eclipse.org/r/#/c/38571/

Comment 12 Aurelien Pupier 2014-12-19 11:11:50 EST

several changes:
- https://git.eclipse.org/r/#/c/38573/ in databinding test plugin
- https://git.eclipse.org/r/#/c/38572/ in forms test plugin

Comment 13 Lars Vogel 2015-01-05 10:36:54 EST

(In reply to Aurelien Pupier from comment #12)
> several changes:
> - https://git.eclipse.org/r/#/c/38573/ in databinding test plugin
> - https://git.eclipse.org/r/#/c/38572/ in forms test plugin

Thanks Aurelient. Merged with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=01b123d4f3397661acb1c2eac08773d204133182 and https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=504834e7341b3ef01b45b142c396b85d9efc4170

Comment 14 Aurelien Pupier 2015-01-05 10:42:13 EST

(In reply to Lars Vogel from comment #13)
> (In reply to Aurelien Pupier from comment #12)
> > several changes:
> > - https://git.eclipse.org/r/#/c/38573/ in databinding test plugin
> > - https://git.eclipse.org/r/#/c/38572/ in forms test plugin
> 
> Thanks Aurelient. Merged with
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=01b123d4f3397661acb1c2eac08773d204133182 and
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=504834e7341b3ef01b45b142c396b85d9efc4170

you're welcome :-)

Comment 15 Lars Vogel 2015-03-17 12:26:38 EDT

Marking as fixed for M6, we can open a new bug for more fixes.