Bug 433341 - Syntax error in TestUtil in org.eclipse.e4.ui.menu.tests
Summary: Syntax error in TestUtil in org.eclipse.e4.ui.menu.tests
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks: 440849
  Show dependency tree
 
Reported: 2014-04-23 17:25 EDT by Lars Vogel CLA
Modified: 2014-11-28 08:15 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-04-23 17:25:09 EDT 
I get a syntax error in appContext.set(IResourceUtilities.class, new ISWTResourceUtilities() {

it complains adornImage must also be implemented. Are others seeing the same error?
Comment 1 Björn Seebeck CLA 2014-05-06 09:08:50 EDT 
Just checked out the code and got this error. A little bit confusing to new committers.
Comment 2 Lars Vogel CLA 2014-05-06 15:23:52 EDT 
Dani, Paul how comes we have a syntax error in our tests? Do we not run  org.eclipse.e4.ui.menu.tests in our automated test run?
Comment 3 Paul Webster CLA 2014-05-06 15:32:08 EDT 
No, that one isn't included in our builds.

We should compare that with the MenuTestSuite in org.eclipse.ui.tests, and if the o.e.ui.tests one is comparable we can remove the other one.
Comment 4 Lars Vogel CLA 2014-07-31 04:28:15 EDT 
Fix for the syntax error and adds README.md for the task to compare with the MenuTestSuite in org.eclipse.ui.tests.

https://git.eclipse.org/r/#/c/30780/
Comment 6 Dani Megert CLA 2014-08-04 10:22:50 EDT 
To consider this done the bundle version needs to be incremented.
Comment 7 Lars Vogel CLA 2014-08-04 14:05:13 EDT 
(In reply to Dani Megert from comment #6)
> To consider this done the bundle version needs to be incremented.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cdaba77c534e1f6b10f60e144ef07ad1c3e522a8
Comment 8 Wojciech Sudol CLA 2014-08-05 11:16:48 EDT 
Verified in I20140804-2000.
Comment 9 Lars Vogel CLA 2014-11-28 08:15:30 EST 
(In reply to Paul Webster from comment #3)
> We should compare that with the MenuTestSuite in org.eclipse.ui.tests, and
> if the o.e.ui.tests one is comparable we can remove the other one.

I prefer we leave them separate to have your e4 menu tests separate from the "old" menu tests.