Description Peter Cigehn 2014-04-17 09:37:03 EDT

When submitting a change using the submit button in the task editor, we had an issue where an error dialog popped up stating "Not Found". The submit as such seemed to work and the change was merged as expected, so we could not really understand what it was that was "Not Found". 

After some debugging it was discovered that the wrong change id was used when getting the change details, after the submit had been performed, causing the "Not Found" error dialog to pop up.

In the method submitRest in the class GerritClient, at the last line, there is a call to the method getChangeDetail:

	return getChangeDetail(id.get(), monitor);

The problem is that id refers to the id of the current patch set, not the id of the change itself. Comparing with other use of getChangeDetail, the id probably should be taken from the parent change instead:

	return getChangeDetail(id.getParentKey().get(), monitor);

When trying this change, the "Not Found" error dialog did not appear any longer.

I guess the reason for this bug to get unnoticed, is that most Gerrit installations have changes with ids in the same range as patch set ids, but for some reason our Gerrit server apparently lacks changes with low number ids like 1, 2 and so on.