Bug 432832 - [Dialogs] Apply button position is inconsistent in the Debug Configurations and Project Properties dialogs
Summary: [Dialogs] Apply button position is inconsistent in the Debug Configurations a...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Robert Roth CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, greatfix
Depends on:
Blocks:
 
Reported: 2014-04-15 10:25 EDT by Norman Yee CLA
Modified: 2015-07-08 23:39 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Norman Yee CLA 2014-04-15 10:25:08 EDT
The Apply button is on the right side of the Project properties dialog and it is on the left in the Debug Configurations dialog.  It would be nice if they were positioned consistently (e.g., both on the right or both on the left).
Comment 1 Mauro Molinari CLA 2014-08-05 08:46:54 EDT
Still valid in I20140606-1215.
Comment 2 Eclipse Genie CLA 2015-03-19 19:47:09 EDT
New Gerrit change created: https://git.eclipse.org/r/44215
Comment 3 Robert Roth CLA 2015-03-19 19:55:36 EDT
I would like to solve this as my "Great Fix for Mars", but I can't assign this to myself and can't add the "greatfix" keyword either, I can only edit the Keywords field.

As for the timeframe, my first take on this is already available on gerrit.
Comment 4 Eclipse Genie CLA 2015-04-21 08:52:07 EDT
New Gerrit change created: https://git.eclipse.org/r/46173
Comment 6 Dani Megert CLA 2015-04-21 10:49:13 EDT
Thanks Robert!
Comment 7 Sarika Sinha CLA 2015-04-26 23:57:23 EDT
Verified using
Eclipse SDK

Version: Mars (4.5)
Build id: I20150426-2000
Comment 8 Robert Roth CLA 2015-05-03 05:08:49 EDT
Could anyone please assign me (would be nice for shameless self-promotion in context of #greatfix)?
Comment 9 Sarika Sinha CLA 2015-05-04 01:23:24 EDT
Done. Thanks Robert.
Comment 10 Jonas Thedering CLA 2015-07-08 11:44:58 EDT
Wouldn't it have been better to swap the "Restore defaults" and "Apply" in the project properties instead? Having "Apply" on the left seems more consistent to me, because it resembles the "OK"/"Cancel" order in the Project Properties dialog and the "Debug"/"Close" order in the Debug Configuration dialog as the left is always the "positive" choice.
Comment 11 Sarika Sinha CLA 2015-07-08 23:39:39 EDT
(In reply to Jonas Thedering from comment #10)
> Wouldn't it have been better to swap the "Restore defaults" and "Apply" in
> the project properties instead? Having "Apply" on the left seems more
> consistent to me, because it resembles the "OK"/"Cancel" order in the
> Project Properties dialog and the "Debug"/"Close" order in the Debug
> Configuration dialog as the left is always the "positive" choice.

Project Properties is a generic dialog provided by Eclipse Platform and is used in all the Eclipse projects, so changing that is not desirable.