Bug 432566 - fix failing EditorRestore and Trac tests
Summary: fix failing EditorRestore and Trac tests
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 normal (vote)
Target Milestone: 3.12   Edit
Assignee: Leo Dos Santos CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2014-04-10 17:48 EDT by Sam Davis CLA
Modified: 2014-06-13 17:36 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2014-04-10 17:48:58 EDT
In http://ci.mylyn.org/job/mylyn-all-snapshot/, EditorRestoreTest.testCloseAllRestore is failing. The Trac tests have been unreliable for a while and we should either fix or disable them.
Comment 1 Leo Dos Santos CLA 2014-05-01 19:14:35 EDT
TracXmlRpcClientTest.testGetWikiPageInfoAllVersions is editing the wiki page Test and then attempting to get information about every version of that page. There have been over 4500+ edits to the page, and the call to TracXmlRpcClient.multiCall attempts to make all 4500+ version info requests at once. I suspect ci.mylyn.org just doesn't have the memory to do that and throws a 500 error in response. This test could be fixed by just editing the Test wiki page history to have fewer entries.
Comment 2 Sam Davis CLA 2014-05-01 19:40:20 EDT
I have started http://ci.mylyn.org/view/Provisioning/job/mylyn-puppet-trac but I'm not sure how those wiki pages contain edits much older than the last time that job ran. If it fixes it we should maybe schedule it to run every 4 months or something.
Comment 3 Sam Davis CLA 2014-05-02 17:07:28 EDT
Reprovisioning doesn't remove the wiki page. It looks like Trac stores wiki pages in a database at /home/tools/trac/var/trac-1.0.1/env/db/trac.db. I am not sure how to edit that or what would happen if we just delete it.
Comment 4 Sam Davis CLA 2014-05-02 19:20:24 EDT
This test failure is disruptive and I don't want to spend any more time trying to figure out how to fix it so I've pushed a review to disable the test. We could reenable it once we know how to delete the wiki page, although I don't see much value in the test.

25897: disable failing Trac test [I2c003740]
https://git.eclipse.org/r/#/c/25897/
Comment 5 Leo Dos Santos CLA 2014-06-02 14:16:32 EDT
I've added a review for fixing the EditorRestore tests

27747: 432566: fix failing EditorRestore tests [I0e726cc1]
https://git.eclipse.org/r/#/c/27747/
Comment 6 Sam Davis CLA 2014-06-02 14:42:28 EDT
Leo figured out that the EditorRestoreTest failure was caused by the tests creating many interaction monitors and never disposing them. Having so many monitors changes the context in unpredictable ways.
Comment 7 Sam Davis CLA 2014-06-02 16:39:35 EDT
The changes have been merged. Thanks Leo!
Comment 8 Sam Davis CLA 2014-06-13 16:50:03 EDT
Now that the final 3.12 build is done, I've cherry-picked the fix onto the 3.12 branch so that the tests will pass.
Comment 9 Leo Dos Santos CLA 2014-06-13 17:36:15 EDT
Nice