Bug 432221 - Snippet editor allows the same keyword twice
Summary: Snippet editor allows the same keyword twice
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Recommenders (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Olav Lenz CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2014-04-08 03:33 EDT by Andreas Sewe CLA
Modified: 2019-07-24 14:36 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2014-04-08 03:33:34 EDT 
In the Snippet Editor, you can add the same keyword twice. "Adding" an existing keyword should either be prevented in the "Enter new keyword" dialog or simply result in no effect. (Personally, I prefer the former solution, as it's less surprising to the user.)
Comment 1 Olav Lenz CLA 2014-04-13 04:56:05 EDT 
https://git.eclipse.org/r/#/c/24907/

Now the input dialog checks whether the user input already exists in the list of keywords or not. If it already exists the user isn't able to add his input it.
Comment 2 Andreas Sewe CLA 2014-05-05 03:12:35 EDT 
Fixed merged a while ago.

@Olav: If you submit a change in Gerrit, please don't hesitate set the associated bug to RESOLVED. (FYI, there's always a second step involved setting it to CLOSED to mark that it stood up to real-world usage.)
Comment 3 Marcel Bruch CLA 2014-06-19 06:34:11 EDT 
Closing for 2.1