Bug 432006 - [WorkbenchLauncher] Select new Workspace via ChooseWorkspaceWithSettingsDialog should allow to copy preferences
Summary: [WorkbenchLauncher] Select new Workspace via ChooseWorkspaceWithSettingsDial...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 4.7 M7   Edit
Assignee: David Weiser CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 515074 511548 516048 516049
  Show dependency tree
 
Reported: 2014-04-04 07:15 EDT by Lars Vogel CLA
Modified: 2017-05-03 04:12 EDT (History)
3 users (show)

See Also:

Attachments
invisible preferences checkbox (23.42 KB, image/png)
2017-05-02 10:14 EDT, Andrey Loskutov CLA 		no flags Details
white border around settings group (27.61 KB, image/png)
2017-05-02 10:26 EDT, Andrey Loskutov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-04-04 07:15:05 EDT 
I think the ChooseWorkspaceWithSettingsDialog should also allow to copy the preference settings.
Comment 1 Szymon Ptaszkiewicz CLA 2014-04-04 07:19:11 EDT 
Moving to IDE.
Comment 2 Lars Vogel CLA 2017-03-19 16:02:51 EDT 
David, could you prepare a patch for the UI change?
Comment 3 Eclipse Genie CLA 2017-03-29 06:53:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/94044
Comment 6 Lars Vogel CLA 2017-04-11 06:05:39 EDT 
Thanks a bunch David, this solves a painful need of developers to transfer their preference settings during workspace switch.

Please validate the fix in tomorrows I-Build, as discussed it is hard / not possible (?) to test this in a runtime workspace as you cannot switch. But calling the class did the correct thing.
Comment 7 Andrey Loskutov CLA 2017-05-02 10:13:28 EDT 
If I click now on the "Copy settings" menu, I get the scrollbar and the "Preferences" is not visible, I will attach the screenshot.

The "Recent Workspaces" does this better: it resizes the dialog if there are no space.
Comment 8 Andrey Loskutov CLA 2017-05-02 10:14:14 EDT 
Created attachment 268116 [details]
invisible preferences checkbox
Comment 9 Andrey Loskutov CLA 2017-05-02 10:26:56 EDT 
Created attachment 268117 [details]
white border around settings group

(In reply to Andrey Loskutov from comment #8)
> Created attachment 268116 [details]
> invisible preferences checkbox

Steps to reproduce: open "Switch to workspace" dialog, click to expand workspaces, click to collapse them, click to expand settings, click to collapse them and now expand them again.

Additional issues:
 - if "workspaces" are expanded, expanding "settings" will hide parts of the list above
 - if workspaces were expanded before switching, next time dialog is opened, "settings" group will have a think white border (!?)
Comment 10 Andrey Loskutov CLA 2017-05-02 10:30:47 EDT 
I've tested on Windows 7 / Linux GTK3, behavior & L&F seem to be mostly same.
Comment 11 Lars Vogel CLA 2017-05-02 13:17:18 EDT 
I suggest to handle the layout issues via Bug 515077. I think not all of them are new.
Comment 12 Eclipse Genie CLA 2017-05-03 04:09:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/96262