431845 – [Themes] [CSS] Simplify dark theme

Bug 431845 - [Themes] [CSS] Simplify dark theme

Summary: [Themes] [CSS] Simplify dark theme

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.5 M6
Assignee:	Stefan Winkler
QA Contact:

URL:
Whiteboard:
Keywords:	greatfix

Depends on:	459961
Blocks:	430199
	Show dependency tree

Reported:	2014-04-02 18:05 EDT by Stefan Winkler
Modified:	2015-03-17 12:05 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stefan Winkler

2014-04-02 18:05:46 EDT

It seems that some of the CSS rules in the dark theme are overly complicated. 
This makes the dark theme less maintainable. (see Bug 419482)

We should analyze how the dark theme CSS can be simplified.

Comment 1 Andrea Guarinoni

2014-04-07 08:39:09 EDT

If every widget will inherit automatically the value of the properties set in its parent (mainly, foreground and background colors) when a specific rule is not set for the widget, then all the dirty hacks related to bug 419482 can be safely removed.

Comment 2 Eclipse Genie

2015-02-15 14:07:09 EST

New Gerrit change created: https://git.eclipse.org/r/41884

Comment 3 Eclipse Genie

2015-03-13 06:34:12 EDT

Gerrit change https://git.eclipse.org/r/41884 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=62453526ec07379e36b8782df2f266924440d005

Comment 4 Lars Vogel

2015-03-13 06:34:22 EDT

Thanks Stefan.

Comment 5 Lars Vogel

2015-03-16 19:58:50 EDT

Dark theme in 4.5.0.N20150315-1630 looks still good to me.

Comment 6 Lars Vogel

2015-03-17 12:05:03 EDT

The section header of the MANIFEST.MF file is not styled anymore after this change. We follow up on this in Bug 430199.