Comment 1 Lars Vogel 2014-03-27 06:02:13 EDT

Created attachment 241316 [details]
Screenshot

Comment 2 Lars Vogel 2014-03-27 06:04:52 EDT

David, what do you think? If you agree, I can provide a patch for that.

Comment 3 Paul Webster 2014-03-27 09:17:42 EDT

All of our documentation talks about the workbench.

PW

Comment 4 Lars Vogel 2014-03-27 09:33:24 EDT

(In reply to Paul Webster from comment #3)
> All of our documentation talks about the workbench.

I agree but the button works as a "Close" button of that intro view.

Comment 5 Tobias Baumann 2014-03-28 18:07:40 EDT

https://git.eclipse.org/r/#/c/24123/

Comment 6 Dani Megert 2014-04-01 08:43:40 EDT

(In reply to Lars Vogel from comment #0)
> I think "Workbench" has little meaning to the average user. Can we replace
> the text with "Close"?

No. The problem is, that it is not supposed to close the welcome page completely but minimize it. See a 3.x build for reference and bug 431704.

Comment 7 Lars Vogel 2014-04-01 09:23:22 EDT

(In reply to Dani Megert from comment #6)
> (In reply to Lars Vogel from comment #0)
> > I think "Workbench" has little meaning to the average user. Can we replace
> > the text with "Close"?
> 
> No. The problem is, that it is not supposed to close the welcome page
> completely but minimize it. See a 3.x build for reference and bug 431704.

Can we call it "Close" for now and rename it to "Minimize" once Bug 431704 is fixed?

Comment 8 Dani Megert 2014-04-01 10:16:40 EDT

(In reply to Lars Vogel from comment #7)
> (In reply to Dani Megert from comment #6)
> > (In reply to Lars Vogel from comment #0)
> > > I think "Workbench" has little meaning to the average user. Can we replace
> > > the text with "Close"?
> > 
> > No. The problem is, that it is not supposed to close the welcome page
> > completely but minimize it. See a 3.x build for reference and bug 431704.
> 
> Can we call it "Close" for now and rename it to "Minimize" once Bug 431704
> is fixed?

The icon would also have to be changed, X is 'Close'. The only other alternative would be to remove the button completely for now. But I really suggest to spend the time for the real fix.

Comment 9 Lars Vogel 2014-04-02 14:47:23 EDT

(In reply to Tobias Baumann from comment #5)
> https://git.eclipse.org/r/#/c/24123/

Tobias, do you want to take Bug 431704 and minimize the part if the button is pressed. If yes you can also use this Bug / Gerrit review to change the text to minimize.

Comment 10 Lars Vogel 2014-09-18 04:33:43 EDT

Marking as WONTFIX.