Comment 1 Lars Vogel 2014-03-25 20:14:11 EDT

https://git.eclipse.org/r/#/c/23901/

Comment 2 Paul Webster 2014-04-01 13:01:18 EDT

John, what's the risk of removing this plugin?  It's not clear from the other bug if we removed support for the 2.0 plugins or if we decided to put it back.

PW

Comment 3 Lars Vogel 2014-04-04 04:30:02 EDT

Dani, do we still support Eclipse 2.0 plug-ins in Luna?

Comment 4 Dani Megert 2014-04-04 04:59:33 EDT

(In reply to Lars Vogel from comment #3)
> Dani, do we still support Eclipse 2.0 plug-ins in Luna?

No. But deleting them now after the API freeze is a no go. We can mark them now for deletion in the next release.

Comment 5 Dani Megert 2014-04-04 05:25:13 EDT

I see you moved the bug to 4.5. Did you nark it for deletion? If not please do so, or file a bug to track this for Luna. Otherwise we won't delete it in 4.5.

Comment 6 Lars Vogel 2014-04-04 05:32:53 EDT

(In reply to Dani Megert from comment #5)
> I see you moved the bug to 4.5. Did you nark it for deletion? If not please
> do so, or file a bug to track this for Luna. Otherwise we won't delete it in
> 4.5.

Sorry, I thought moving this bug to 4.5 was the right think. I moved it back. 

> Did you nark it for deletion?

I don't know that this mean. Where do I mark something for deletion?

Comment 7 Dani Megert 2014-04-04 05:38:16 EDT

(In reply to Lars Vogel from comment #6)
> (In reply to Dani Megert from comment #5)
> > I see you moved the bug to 4.5. Did you nark it for deletion? If not please
> > do so, or file a bug to track this for Luna. Otherwise we won't delete it in
> > 4.5.
> 
> Sorry, I thought moving this bug to 4.5 was the right think. I moved it
> back. 
> 
> > Did you nark it for deletion?
> 
> I don't know that this mean. Where do I mark something for deletion?

/org.eclipse.platform.doc.isv/porting/removals.html

Comment 8 Lars Vogel 2014-04-22 12:15:22 EDT

(In reply to Dani Megert from comment #7)
> /org.eclipse.platform.doc.isv/porting/removals.html

Thanks, please review https://git.eclipse.org/r/25371

Comment 9 Lars Vogel 2014-04-28 12:16:02 EDT

Applied with https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4ff8270cbfded1b28cc4665600ecec1f3fe789e2 as we have to close all bugs today or move them out to 4.5.

Comment 10 Lars Vogel 2014-04-29 06:07:28 EDT

Dani, can you verify if the description is OK?

Comment 11 Dani Megert 2014-05-06 09:35:51 EDT

(In reply to Lars Vogel from comment #10)
> Dani, can you verify if the description is OK?

Not quite. The bug URL is wrong, and both, type and plug-in name should be inside <code>. I've fixed that and also replaced "The Eclipse platform ui team " with "we".

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=220b110bb35fd6f5b448e374264547783984cc0d

Reopening to do the real work during 4.5.

Comment 12 Lars Vogel 2014-05-06 09:42:41 EDT

(In reply to Dani Megert from comment #11)
> (In reply to Lars Vogel from comment #10)
> > Dani, can you verify if the description is OK?
> 
> Not quite. The bug URL is wrong, and both, type and plug-in name should be
> inside <code>. I've fixed that and also replaced "The Eclipse platform ui
> team " with "we".
> 
> Fixed with
> http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/
> ?id=220b110bb35fd6f5b448e374264547783984cc0d
> 
> Reopening to do the real work during 4.5.

Thanks.

Comment 13 Lars Vogel 2014-07-15 19:54:46 EDT

This Gerrit review removes the org.eclipse.ui.workbench.compatibility plug-in from the build and the Git repo:

https://git.eclipse.org/r/#/c/23901/

Comment 14 Lars Vogel 2014-07-15 19:59:46 EDT

https://git.eclipse.org/r/#/c/29940/ removes ICompatibleWorkbenchPage from org.eclipse.ui.workbench

Comment 15 Lars Vogel 2014-07-16 04:55:20 EDT

(In reply to Lars Vogel from comment #13)
> https://git.eclipse.org/r/#/c/23901/

Applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=90184d2009e64b0763b121fc952b63cb9331598e

Comment 16 Lars Vogel 2014-07-16 13:54:50 EDT

(In reply to Lars Vogel from comment #14)
> https://git.eclipse.org/r/#/c/29940/ removes ICompatibleWorkbenchPage from
> org.eclipse.ui.workbench

API tools did not report any issues with this change (to my surprise) so I committed it with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=708bfddad74e7ddcdd83db1ffe6dba1ef707020a

For the update of the migration guide I opened Bug 439743

Comment 17 Lars Vogel 2014-08-05 14:23:09 EDT

4.5.0.I20140804-2000 works fine AFAICS