Bug 431157 - when creating a Gerrit repository, accept URLs which include hash character
Summary: when creating a Gerrit repository, accept URLs which include hash character
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.5   Edit
Assignee: Michael Keppler CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2014-03-25 15:37 EDT by Michael Keppler CLA
Modified: 2014-12-09 18:20 EST (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (859 bytes, application/octet-stream)
2014-03-25 15:40 EDT, Michael Keppler CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2014-03-25 15:37:30 EDT 
Copy the URL from the "My reviews" page of the Eclipse gerrit review installation out of your browser, that is https://git.eclipse.org/r/#/

Paste it into Mylyn for creating a new gerrit connector. This fails with an InvocationTargetException due to the fragment part of the URL (everything starting with the hash character). The gerrit connector should recognize and handle this situation by removing the fragment part.
Comment 1 Michael Keppler CLA 2014-03-25 15:40:52 EDT 
patch available at https://git.eclipse.org/r/23883
Comment 2 Michael Keppler CLA 2014-03-25 15:40:54 EDT 
Created attachment 241236 [details]
mylyn/context/zip
Comment 3 Sam Davis CLA 2014-12-09 18:20:08 EST 
Thanks very much for the contribution!