Bug 431130 - [Preferences] FieldEditor.adjustForNumColumns(int numColumns) client access
Summary: [Preferences] FieldEditor.adjustForNumColumns(int numColumns) client access
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2014-03-25 11:32 EDT by Phaedrus The Greek CLA
Modified: 2015-04-03 11:24 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Phaedrus The Greek CLA 2014-03-25 11:32:16 EDT 
It would be useful if     FieldEditor.adjustForNumColumns(int numColumns) were accessible outside package.   I have subclassed "WizardPage" as "FieldEditorWizardPage" and would like to have my own adjustGridLayout() method, similar to org.eclipse.jface.preference.FieldEditorPreferencePage.adjustGridLayout() , however I cannot access adjustForNumColumns on each FieldEditor.

Is this request reasonable or insane?

Appreciate your time and expertise!

Jay
Comment 1 Brian de Alwis CLA 2014-03-25 14:24:26 EDT 
The changes to FieldEditor for bug 80429 was to allow use of the FieldEditors from outside of preference pages, so it doesn't seem like an unreasonable request.

Unfortunately we can't make FieldEditor#adjustForNumColumns() public: that is an API break as any existing implementations would be seen to be reducing the visibility of the method.

I think the best we could do is introduce a parallel public method like adjustForGridLayout(int numColumns) that would delegate to the existing adjustForNumColumns().  We should also document the assumption that the field editors are instantiated with a parent with a GridLayout.  As we're in M7 (no API changes), this change will have to wait until 4.5.