Bug 430638 - [CSS] Mark deprecated extension points for removal
Summary: [CSS] Mark deprecated extension points for removal
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 RC4   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks: 436503
  Show dependency tree
 
Reported: 2014-03-18 16:23 EDT by Lars Vogel CLA
Modified: 2014-08-04 15:23 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-18 16:23:51 EDT 
org.eclipse.e4.ui.css.core defines two extension points which are deprecated. I suggest to remove them. I don't know if they work or not but as CSS is not official API, I think we are save to remove them.

org.eclipse.e4.u.css.core.elementProvider -> Typo
org.eclipse.e4.ui.css.swt.property.handler -> Replaced by org.eclipse.e4.ui.css.core.property.handler
Comment 1 Lars Vogel CLA 2014-03-18 16:24:54 EDT 
Daniel, what do you think? OK to delete them?
Comment 2 Lars Vogel CLA 2014-03-18 16:25:50 EDT 
https://git.eclipse.org/r/23562
Comment 3 Paul Webster CLA 2014-03-18 17:27:35 EDT 
You should announce this on the e4-dev and platform-ui-dev lists, just in case.

PW
Comment 4 Lars Vogel CLA 2014-03-18 17:32:30 EDT 
(In reply to Paul Webster from comment #3)
> You should announce this on the e4-dev and platform-ui-dev lists, just in
> case.

I think this is not that urgent, so I plan to do this after Luna.
Comment 5 Brian de Alwis CLA 2014-03-26 17:30:07 EDT 
Oops, wrong target
Comment 6 Brian de Alwis CLA 2014-03-26 17:30:47 EDT 
Sorry for the noise: wrong bug.  Clearly time to go home.
Comment 7 Dani Megert CLA 2014-04-10 09:45:06 EDT 
(In reply to Paul Webster from comment #3)
> You should announce this on the e4-dev and platform-ui-dev lists, just in
> case.
> 
> PW

This should follow the normal deprecation policy:
https://wiki.eclipse.org/Eclipse/API_Central/Deprecation_Policy
Comment 8 Brian de Alwis CLA 2014-04-10 16:48:22 EDT 
Do those rules apply if these extension points weren't official API?
Comment 9 Dani Megert CLA 2014-04-11 05:09:46 EDT 
(In reply to Brian de Alwis from comment #8)
> Do those rules apply if these extension points weren't official API?

They don't have "internal" in the id nor could I find something saying they are not "official" in their definition. Or did I miss something?
Comment 10 Brian de Alwis CLA 2014-04-11 09:59:45 EDT 
(In reply to Dani Megert from comment #9)
> They don't have "internal" in the id nor could I find something saying they
> are not "official" in their definition. Or did I miss something?

All of the org.eclipse.e4.ui.css.* bundles have versions 0.X and all of their packages are internal.

But the extension points were present in 4.2, so deleting them for 4.5 should be fine, right?
Comment 11 Dani Megert CLA 2014-04-14 05:42:07 EDT 
(In reply to Brian de Alwis from comment #10)
> (In reply to Dani Megert from comment #9)
> > They don't have "internal" in the id nor could I find something saying they
> > are not "official" in their definition. Or did I miss something?
> 
> All of the org.eclipse.e4.ui.css.* bundles have versions 0.X and all of
> their packages are internal.
> 
> But the extension points were present in 4.2, so deleting them for 4.5
> should be fine, right?

Yes, but it has to be marked for removal in the 4.4 release as per
https://wiki.eclipse.org/Eclipse/API_Central/Deprecation_Policy
I've adjusted the target to keep that in mind for 4.4.
Comment 12 Lars Vogel CLA 2014-06-03 04:38:43 EDT 
(In reply to Dani Megert from comment #11)

> Yes, but it has to be marked for removal in the 4.4 release as per
> https://wiki.eclipse.org/Eclipse/API_Central/Deprecation_Policy

Marked for removal Gerrit review:

https://git.eclipse.org/r/#/c/27791/
Comment 13 Dani Megert CLA 2014-06-03 07:59:09 EDT 
(In reply to Lars Vogel from comment #12)
> (In reply to Dani Megert from comment #11)
> 
> > Yes, but it has to be marked for removal in the 4.4 release as per
> > https://wiki.eclipse.org/Eclipse/API_Central/Deprecation_Policy
> 
> Marked for removal Gerrit review:
> 
> https://git.eclipse.org/r/#/c/27791/

See my comments over there.
Comment 14 Lars Vogel CLA 2014-06-03 08:24:31 EDT 
(In reply to Dani Megert from comment #13)
> See my comments over there.

Thanks. Fixed and applied with https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=a48e16576f77daa158166d9dc11487fd41de26d1
Comment 15 Lars Vogel CLA 2014-06-03 08:25:09 EDT 
Is "Fixed" the correct status or shall I move the bug to Eclipse 4.5?
Comment 16 Dani Megert CLA 2014-06-03 08:32:47 EDT 
(In reply to Lars Vogel from comment #15)
> Is "Fixed" the correct status or shall I move the bug to Eclipse 4.5?

We should rename this one to "Mark ... for removal" and create a new bug for 4.5.
Comment 18 Dani Megert CLA 2014-08-04 15:20:47 EDT 
(In reply to Lars Vogel from comment #17)
> Increased bundle version
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=5acfb9bc1526aac31779740a78f1bece524073da

Was this really meant for this bug?
Comment 19 Lars Vogel CLA 2014-08-04 15:23:52 EDT 
(In reply to Dani Megert from comment #18)
> Was this really meant for this bug?

Sorry, Bug 436503 is the correct one.