Bug 430126 - [QuickAccess] Quick Access should save previous choices between sessions
Summary: [QuickAccess] Quick Access should save previous choices between sessions
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.3.2   Edit
Hardware: PC Windows 7
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2014-03-11 13:51 EDT by Eduardo Simioni CLA
Modified: 2016-11-09 17:07 EST (History)
4 users (show)

See Also:


Attachments
workspace reproducing the issue (4.30 MB, application/octet-stream)
2015-03-30 18:09 EDT, Eduardo Simioni CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Simioni CLA 2014-03-11 13:51:51 EDT
It is very annoying that your previous choices from quick access field are not saved. Whenever you restart Eclipse the list is clean again which kind of defeats the purpose of it.

I remember this worked at some point, probably before Kepler. I even have one Eclipse instance which was upgraded via Eclipse updates and still keeps the previous choices that were saved before the issue, it doesn't save new ones though.
Comment 1 Tomasz Zarna CLA 2015-03-02 11:32:47 EST
This works fine to me, using Luna SR1 (4.4.1, 20140925-1800). Eduardo, feel free to reopen if you still think this is an issue.
Comment 2 Eduardo Simioni CLA 2015-03-20 16:29:17 EDT
It doesn't work for me, on the very same version you mentioned Luna SR1 (4.4.1, 20140925-1800).

I don't know which information I could provide you to help finding the cause.
Please let me know what I could do to help.
Comment 3 Patrik Suzzi CLA 2015-03-25 22:05:04 EDT
I'm not able to reproduce the bug on Eclipse Mars (4.5), Build: I20150324-0800
Comment 4 Christian Georgi CLA 2015-03-29 12:14:55 EDT
(In reply to Patrik Suzzi from comment #3)
> I'm not able to reproduce the bug on Eclipse Mars (4.5), Build:
> I20150324-0800

I can't reproduce it either.  Propose closing this bug.
Comment 5 Eduardo Simioni CLA 2015-03-29 12:26:15 EDT
I can still reproduce it, always, you didn't ask me for any data.
It shouldn't be closed without any investigation.
Comment 6 Tomasz Zarna CLA 2015-03-30 06:49:44 EDT
(In reply to Eduardo Simioni from comment #2)
> I don't know which information I could provide you to help finding the cause.
> Please let me know what I could do to help.

Eduardo, if possible, please attach a minimal workspace (zipped) for which it doesn't work for you i.e. Quick Access is not remembered. You're on Windows 7, correct?
Comment 7 Eduardo Simioni CLA 2015-03-30 18:09:43 EDT
Created attachment 252017 [details]
workspace reproducing the issue
Comment 8 Eduardo Simioni CLA 2015-03-30 18:22:58 EDT
I have created this brand new workspace (attached) with a simple project to test.
In the class I have added two literal strings, then followed these steps:

1) Used quick access to convert one of the strings to a constant: "Extract Constant".

2) Exited Eclipse

3) Started Eclipse - Reopening the workspace

4) Selected the second string

5) Hit Command (Control) + 3 to bring up Quick Access

6) No previous choices are presented


Inside the same session I get "Previous Choices" as expected, but if I exit and open the workspace again, it never presents "Previous Choices".

Initially I have reported this against Windows 7, but it also occurs on OS X 10.10.2 which is the one I currently use. So it doesn't seem to be platform related.
Comment 9 Patrik Suzzi CLA 2016-01-24 06:22:24 EST
Actually, I was able to reproduce it on Neon ( I20160119 ). 

The error happens only when using your zipped workspace, 
and not when using my workspace or a clean workspace.

I've an observation: When I load the zipped workspace, I see a series of exceptions related to cocoa (which is Mac stuffs). Assuming you are on Windows, there is no point in having cocoa failures when you launch your workspace. 

Example:
!MESSAGE Unable to load class 'org.eclipse.e4.ui.workbench.renderers.swt.cocoa.ArrangeWindowHandler' from bundle '83'
!STACK 0
java.lang.ClassNotFoundException: org.eclipse.e4.ui.workbench.renderers.swt.cocoa.ArrangeWindowHandler cannot be found by org.eclipse.e4.ui.workbench.renderers.swt_0.14.0.qualifier
	at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:444)
etc..

There are 6 errors like above, happening for the following classes: ArrangeWindowHandler, MinimizeWindowHandler, FullscreenWindowHandler, ZoomWindowHandler, CloseDialogHandler and CocoaUIHandler


My theory is: the workspace errors have effect on this "Quick Access" bug. 

Could you please try to solve the error in the workspace and see if the error shows again ?

Thanks!
Comment 10 Eduardo Simioni CLA 2016-02-03 09:51:37 EST
Patrik, the strange thing is that the zipped workspace I've provided is a clean workspace!
I've created it on the day that I've attached it here.
It was not copied from other, it was created in an empty folder.

I don't have enough knowledge nor time to fix the other errors in order to confirm your theory.
Maybe another bug should be reported for the team responsible for them?
Comment 11 Lars Vogel CLA 2016-11-09 17:07:03 EST
Works for me, if I have no errors. Please reopen if you can reproduce with a fresh workspace.