Bug 429732 - [KeyBindings] Support Ctrl+Tab for editor switching instead of Ctrl+F6
Summary: [KeyBindings] Support Ctrl+Tab for editor switching instead of Ctrl+F6
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Paul Elder CLA
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2014-03-06 01:39 EST by Lars Vogel CLA
Modified: 2014-03-17 10:51 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-06 01:39:41 EST
I think Ctrl+Tab it the web standard for switching between tabs. We use it for tab between the toolbars, which seems little useful. Our shortcut Ctrl+F6 seems a bit uncommon for switch tabs (editors)

Maybe we should switch the shortcuts?
Comment 1 Wojciech Sudol CLA 2014-03-06 05:18:31 EST
+1
Another advantage of Ctrl+Tab (and Ctrl+Shift+Tab for opposite direction) is that it can be easily pressed with one hand.
Comment 2 Paul Webster CLA 2014-03-06 05:56:33 EST
Switching between tabs is ALT+ left and right arrow.  We want CTRL+TAB to do what the OS default does, which is traverse different UI elements for accessibility purposes.

Can you even set CTRL+TAB to next/previous editor?

PW
Comment 3 Timo Kinnunen CLA 2014-03-06 07:06:00 EST
(In reply to comment #2)
> Can you even set CTRL+TAB to next/previous editor?

You can (tried on Windows 8.1) but I wouldn't. Instead bind Ctrl-Tab/Ctrl-Shift-Tab to Next Tab/Previous Tab actions, it works much better! On Windows Tab and Shift-Tab already switch between UI elements, so that case is still covered. Also I'm happy to confirm Next Tab/Previous Tab match what the same shortcuts do in Internet Explorer 11, so that's OK too.
Comment 4 Lars Vogel CLA 2014-03-06 07:32:46 EST
(In reply to Timo Kinnunen from comment #3)

> You can (tried on Windows 8.1) but I wouldn't. Instead bind
> Ctrl-Tab/Ctrl-Shift-Tab to Next Tab/Previous Tab actions, it works much
> better! On Windows Tab and Shift-Tab already switch between UI elements, so
> that case is still covered. Also I'm happy to confirm Next Tab/Previous Tab
> match what the same shortcuts do in Internet Explorer 11, so that's OK too.

I'm not sure what is working and what is not working? Are you saying ALT+ left and right arrow works fine?
Comment 5 Lars Vogel CLA 2014-03-06 07:35:25 EST
(In reply to Paul Webster from comment #2)
> Switching between tabs is ALT+ left and right arrow.  We want CTRL+TAB to do
> what the OS default does, which is traverse different UI elements for
> accessibility purposes.

Ok, did not know that. Should we close this bug as invalid?
Comment 6 Timo Kinnunen CLA 2014-03-06 08:31:14 EST
(In reply to comment #4)
> I'm not sure what is working and what is not working? Are you saying ALT+ left
> and right arrow works fine?

Sorry, sloppy wording. These are the points I was making:

1) Setting shortcut Ctrl+Tab/Ctrl+Shift+Tab to Next Editor/Previous Editor is possible.
2) Next Editor/Previous Editor show a popup list of editors by name in Most Recently Used order, which didn't match my expectations (they don't "work").
3) Setting shortcut Ctrl+Tab/Ctrl+Shift+Tab to Next Tab/Previous Tab is possible.
4) Executing Next Tab/Previous Tab in Eclipse and pressing Ctrl+Tab/Ctrl+Shift+Tab in Internet Explorer 11 perform the exact same function.
5) Pressing Tab/Shift+Tab in Eclipse (outside source code editors) already performs the exact same function as those shortcuts do elsewhere in Windows.
Comment 7 Timo Kinnunen CLA 2014-03-06 09:04:59 EST
Additionally and unrelated to the previous, shortcuts Alt+Right/Alt+Left are set to Forward History/Backward History. These actions are only tangentially related to tabs. To see what I mean, in Preferences - General - Editors, set Close editors automatically to enabled and set Number of opened editors before closing to 1*, then close all opened editors and start navigating source code. Now, tabs are still in use but the Forward History/Backward History actions can be seen to actually do the same thing that browsers do when navigating the history within a single tab.

*) There is Show multiple editor tabs but it doesn't seem to have any effect, otherwise it could have been chosen for this demonstration too.
Comment 8 Lars Vogel CLA 2014-03-17 10:51:09 EDT
I mark my own bug as WORKFORME, I agree the current keybindings are ok and we should not try to interfere with the OS.