Bug 429521 - make welcome screen graphics/color consistent with new logo
Summary: make welcome screen graphics/color consistent with new logo
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 426260
  Show dependency tree
 
Reported: 2014-03-03 18:56 EST by David Williams CLA
Modified: 2014-04-29 04:31 EDT (History)
3 users (show)

See Also:


Attachments
welcome screen needs new "logo" (144.18 KB, image/png)
2014-03-03 18:56 EST, David Williams CLA
no flags Details
What's New - Screenshot (38.66 KB, image/png)
2014-03-04 05:54 EST, Noopur Gupta CLA
no flags Details
Welcome screen: before and after (117.10 KB, image/png)
2014-04-29 03:54 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-03-03 18:56:36 EST
Created attachment 240487 [details]
welcome screen needs new "logo"

I'll attach picture of one of the current pages ... 

I think there are several "themes", though ... not sure if same image is used in all of them? 

As far as I can see, the _main_ image to change is 
/org.eclipse.sdk/intro-eclipse.png
which is 106x60 image with transparent background. 

In the attached welcome screen, I've circled in red what I _think_ is the intro-eclipse.png ... but, having trouble finding it in "code".
Comment 1 Noopur Gupta CLA 2014-03-04 05:54:37 EST
Created attachment 240500 [details]
What's New - Screenshot

Also, we have the old Eclipse icon for "Eclipse Platform" in the "What's New" and "Migrate" sections of Welcome page. See attached screenshot.
Comment 2 Dani Megert CLA 2014-03-04 12:04:11 EST
(In reply to Noopur Gupta from comment #1)
> Created attachment 240500 [details]
> What's New - Screenshot
> 
> Also, we have the old Eclipse icon for "Eclipse Platform" in the "What's
> New" and "Migrate" sections of Welcome page. See attached screenshot.

Those are the relevant icons for that:

/org.eclipse.platform/images/topiclabel/wn_eclplatform48_hov.gif
/org.eclipse.platform/images/topiclabel/wn_eclplatform48.gif
Comment 3 Markus Keller CLA 2014-04-23 12:56:41 EDT
(In reply to David Williams from comment #0)
> In the attached welcome screen, I've circled in red what I _think_ is the
> intro-eclipse.png ... but, having trouble finding it in "code".

/org.eclipse.platform/plugin.xml contains:
          <property
          		name="introBrandingImage"
          		value="product:intro-eclipse.png"/>

and eclipse.platform.ua/org.eclipse.ui.intro.universal/introContent.xml contains:

       	<img src="$introBrandingImage$" alt="$introBrandingImageText$"/>

There's probably some glue code in the Welcome page that replaces $xxx by the defined property value.
Comment 4 David Williams CLA 2014-04-29 03:54:55 EDT
Created attachment 242442 [details]
Welcome screen: before and after

This screen shot shows my plan for replacing the logo on the "welcome screen" -- showing "current" and "Luna" comparison. 

I simply got one of the official  logos from
www.eclipse.org/artwork 
and scaled it down, made it transparent and positioned it "manually" so it'd show at the right position. 

I hadd original thought its background should change, for a consistent, fresh look, but a) I think it looks mostly ok, as it is, and b) changing the background is kind of complicated. 

Just to document it, that banner background is created by drawing hundreds of jpeg files 60 pixels high, and 1 pixel wide in 
org.eclipse.ui.intro.universal
in the "slate" theme, in root.css

#root {
    background-image : url("../graphics/rootpage/root_banner.jpg");
	background-position : top left;
	background-repeat : repeat-x;
}

I experimented with that, but then the "go to desktop" button would also have to be changed, since it's a jpg, with a background that matches "root_banner.jpg" ... so ... will leave for improvements in future. 

= = = = =
TODO: we may want to add something to "about.html" file, that mentions the 
logo is trademarked by Eclipse Foundation and to see http://www.eclipse.org/logotm

just so it doesn't appear to be part of the normal EPL?
Comment 5 David Williams CLA 2014-04-29 04:12:53 EDT
(In reply to Dani Megert from comment #2)
> (In reply to Noopur Gupta from comment #1)
> > Created attachment 240500 [details]
> > What's New - Screenshot
> > 
> > Also, we have the old Eclipse icon for "Eclipse Platform" in the "What's
> > New" and "Migrate" sections of Welcome page. See attached screenshot.
> 
> Those are the relevant icons for that:
> 
> /org.eclipse.platform/images/topiclabel/wn_eclplatform48_hov.gif
> /org.eclipse.platform/images/topiclabel/wn_eclplatform48.gif

I won't give screen shots for this part of the fix, but will say I plan to use "png" files, with transparent backgrounds, instead of GIF files (the current ones have a sort of funky shaped bit of "white back ground" so background would be hard/impossible to change ... (which these two PNG files won't fix ... but, seems that's the correct direction).  

And ... I'm not sure if the "rules" are documented somewhere, but, by observation I just inferred following: 
- Even though they are "48x48" icons, the actual image is smaller than most 48x48 icons ... approximate 1/2 or 2/3rds as large? 
- The "hover effect" in this case appears to be achieved by making the "hov" icons 2 or 3 pixels smaller ... from the upper left, leaving the baseline of lower right the same. 

And .. it appears several places mistakenly used same icon for both "hover" and "not hover" ... this matches some observations before I made any changes ... but ... deserves some review or testing to make sure it all works and there's not some "secret sauce" to using the same name. 

= = = =

Now ... to get all this checked in before 8 AM build :/
Comment 6 David Williams CLA 2014-04-29 04:31:29 EDT
Commit for "banner logo" image: 

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=28fa66d483a2a1930a7dfa1187c232a4e7278515


Commit for images and other files for "what's new" and "migrate" items. 

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=6d6486d5500e423f14f7160c540cd929028f6e80

Note: I did delete the two 'gif' files I replaced with 'png' files. 

And, in case you are wondering ... I check the "build.properties" and appears everything should still be exported correctly since the whole directories are specified there images/ and intro/