Bug 429466 - ContextFunction contribution should depend on service.ranking
Summary: ContextFunction contribution should depend on service.ranking
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 404461 (view as bug list)
Depends on:
Blocks: 392977
  Show dependency tree
 
Reported: 2014-03-03 09:30 EST by Thomas Schindl CLA
Modified: 2014-03-06 09:44 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2014-03-03 09:30:46 EST 
Currently the context functions are registered in the order returned from BundleContext.getServiceReferences() which means highest first (which is an Equinox specific behavior) so if there are 2 services registered for the same key the one with the lower rank would win.

We should sort the services in reverse order as the first step.
Comment 1 Thomas Schindl CLA 2014-03-03 10:01:09 EST 
Patch with test case is at https://git.eclipse.org/r/22775
Comment 3 Lars Vogel CLA 2014-03-04 13:40:04 EST 
*** Bug 404461 has been marked as a duplicate of this bug. ***
Comment 4 Thomas Schindl CLA 2014-03-04 13:47:02 EST 
Well we need a 2nd one which deals with the dynamics appropriately - left that unmodified to get the change into M6 which is required to get a RAP port up and running!
Comment 5 Dani Megert CLA 2014-03-05 02:58:27 EST 
(In reply to Thomas Schindl from comment #2)
> pushed fix as
> http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/
> ?id=0ded8ebc0f4e94f0bc6c3d1b6a3de1d8699415e4

This causes new compile warnings in our official build, see bug 429634.
Comment 6 Thomas Schindl CLA 2014-03-06 09:44:31 EST 
checked in I20140305-2000