Bug 429086 - [GTK3] Display.java uses gdk_colormap_get_system which are not defined in GTK3
Summary: [GTK3] Display.java uses gdk_colormap_get_system which are not defined in GTK3
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Sami Wagiaalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2014-02-25 15:03 EST by Sami Wagiaalla CLA
Modified: 2014-02-26 05:22 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Wagiaalla CLA 2014-02-25 15:03:02 EST 
Here is the snippet of code:

long /*int*/ colormap = OS.gdk_colormap_get_system();
OS.gdk_colormap_alloc_color(colormap, gdkColor, true, true);
COLOR_LINK_FOREGROUND = gdkColor;

COLOR_LINK_FOREGROUND needs to be initialized in a way compatible with GTK3
Comment 1 Alexander Kurtakov CLA 2014-02-26 03:42:53 EST 
Thanks for catching this.
Comment 2 Alexander Kurtakov CLA 2014-02-26 04:36:30 EST 
Arun, do we still have to block GTK3 bug ? I thought of this bug as some kind of tracking while enabling gtk 3.x , now that it's preferred I ignored it but seems like you still do it. If you need it for smth I can do it so you don't have to go after me ?
Comment 3 Arun Thondapu CLA 2014-02-26 04:50:39 EST 
(In reply to Alexander Kurtakov from comment #2)
> Arun, do we still have to block GTK3 bug ? I thought of this bug as some
> kind of tracking while enabling gtk 3.x , now that it's preferred I ignored
> it but seems like you still do it. If you need it for smth I can do it so
> you don't have to go after me ?

Hi Alex, you're right that this bug was used to track the GTK3 related issues while enabling the port. However, we intend to continue using it to track the issues being reported against GTK3, at least till Luna (which is the official release with GTK3 support) releases officially. We can cease to use the tracking bug after that.

BTW, I think there is a problem with the patch for this bug. I have added a gerrit comment. Thanks!
Comment 4 Alexander Kurtakov CLA 2014-02-26 04:56:02 EST 
New patch: https://git.eclipse.org/r/#/c/22551/ .

I'll start blocking gtk3 tracker bug in this case.
Comment 5 Arun Thondapu CLA 2014-02-26 05:22:03 EST 
(In reply to Alexander Kurtakov from comment #4)
> New patch: https://git.eclipse.org/r/#/c/22551/ .
> 
> I'll start blocking gtk3 tracker bug in this case.

Thanks Alex!