Bug 428643 - Modify MenuManagerEventHelper to not access static fields directly
Summary: Modify MenuManagerEventHelper to not access static fields directly
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 392977
  Show dependency tree
 
Reported: 2014-02-20 08:25 EST by Thomas Schindl CLA
Modified: 2014-05-30 11:16 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2014-02-20 08:25:04 EST 
Currently MenuManagerEventHelper fields are accessed directly it would be good to modify this to use one of the following patterns:

MenuManagerEventHelper.getInstance().set.... or

MenuManagerEventHelper.set...

This way RAP could provide a custom implementation bound to the session
Comment 1 Thomas Schindl CLA 2014-02-20 08:42:47 EST 
https://git.eclipse.org/r/22301
Comment 3 Lars Vogel CLA 2014-02-21 03:53:18 EST 
Follow-up commit to remove the introduced whitespace, looks like my comment in the Gerrit review was overlooked.

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=318e8263b03a910d9f66accbe63f87e744cf004d
Comment 4 Paul Webster CLA 2014-02-21 05:41:33 EST 
(In reply to Lars Vogel from comment #3)
> Follow-up commit to remove the introduced whitespace, looks like my comment
> in the Gerrit review was overlooked.

Sorry Lars, I saw your comment and then forgot about it in my rush to wrap up this issue.

PW
Comment 5 Eric Moffatt CLA 2014-05-30 11:16:18 EDT 
Verified (visually) in 4.4.0.I20140528-2000.