Bug 428378 - enable breakpoints in context by default
Summary: enable breakpoints in context by default
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal with 3 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 428236 428389
Blocks:
  Show dependency tree
 
Reported: 2014-02-17 16:03 EST by Sam Davis CLA
Modified: 2017-04-02 15:29 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2014-02-17 16:03:35 EST
Before we can enable breakpoints in context by default, we need to collect feedback and address the known issues. We can use this bug for that purpose.
Comment 1 Sam Davis CLA 2014-02-17 17:23:30 EST
This is a followup to bug 155333.
Comment 2 Sam Davis CLA 2014-02-17 17:24:38 EST
Breakpoints are not visible on the context preview page if they are not in the breakpoints view (i.e. when the task is not active).
Comment 3 Sam Davis CLA 2014-02-17 19:46:59 EST
I somehow ended up with 2 identical breakpoints in a context. When deactivating the task, only one of them is removed. If I delete the other one and activate again, it again creates 2 of them, and when I deactivate one is left behind. Looking at the saved context, there are indeed 2 identical copies of the breakpoints. Here's one:

bc. <breakpoint enabled="true" persistant="true" registered="true">
<resource path="/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/commands/AddTaskRepositoryHandler.java" type="1"/>
<marker charStart="1324" lineNumber="33" type="org.eclipse.jdt.debug.javaLineBreakpointMarker">
<attrib name="enabled" value="true"/>
<attrib name="org.eclipse.debug.core.id" value="org.eclipse.jdt.debug"/>
<attrib name="workingset_name" value=""/>
<attrib name="org.eclipse.jdt.debug.ui.JAVA_ELEMENT_HANDLE_ID" value="=org.eclipse.mylyn.tasks.ui/src&lt;org.eclipse.mylyn.internal.tasks.ui.commands{AddTaskRepositoryHandler.java[AddTaskRepositoryHandler"/>
<attrib name="org.eclipse.jdt.debug.core.suspendPolicy" value="2"/>
<attrib name="type" value="org.eclipse.jdt.debug.javaLineBreakpointMarker"/>
<attrib name="org.eclipse.jdt.debug.core.installCount" value="0"/>
<attrib name="persistant" value="true"/>
<attrib name="workingset_id" value="org.eclipse.debug.ui.breakpointWorkingSet"/>
<attrib name="org.eclipse.mylyn.debug.ui.breakpointId" value="breakpoint[9759.035645857617]"/>
<attrib name="message" value="Line breakpoint:AddTaskRepositoryHandler [line: 33] - execute(ExecutionEvent)"/>
<attrib name="registered" value="true"/>
<attrib name="charStart" value="1324"/>
<attrib name="path" value="/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/commands/AddTaskRepositoryHandler.java"/>
<attrib name="charEnd" value="1374"/>
<attrib name="org.eclipse.debug.core.enabled" value="true"/>
<attrib name="org.eclipse.jdt.debug.core.typeName" value="org.eclipse.mylyn.internal.tasks.ui.commands.AddTaskRepositoryHandler"/>
</marker>
</breakpoint>
Comment 4 Sam Davis CLA 2014-02-25 18:48:57 EST
(In reply to comment #3)

This seems to happen quite a lot. I have several duplicated breakpoints in one context.
Comment 5 Sebastian Schmidt CLA 2014-02-26 03:31:01 EST
(In reply to Sam Davis from comment #4)

Can you see a pattern when this happens?
Comment 6 Sam Davis CLA 2014-02-26 19:04:59 EST
No, I haven't seen a pattern so far.
Comment 7 Sam Davis CLA 2014-08-14 00:56:23 EDT
When starting up with a task active, the UI can freeze for about 40 seconds while breakpoints are imported. Here's a fix:

31613: 428378: import breakpoints in the background [I9a4a768c]
https://git.eclipse.org/r/#/c/31613/
Comment 8 Jaxsun McCarthy Huggan CLA 2016-09-23 00:59:28 EDT
Completing this would entail:

* All reported defects against the breakpoint context storage are resolved
* The preference to store breakpoints in Task Context is set to on by default
** changing the default preference value should activate this feature for all users unless they had specifically disabled it.
** We should leave the preference intact, since even after we resolve all the glaring issues there could still would not fit all users' workflows
* Any warnings in the preferences which have been resolved are removed
Comment 9 Eclipse Genie CLA 2017-04-02 15:29:53 EDT
New Gerrit change created: https://git.eclipse.org/r/94273
Comment 10 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn