Bug 428323 - [Workbench] Wrong action definition in ActionFactory
Summary: [Workbench] Wrong action definition in ActionFactory
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Tobias Baumann CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2014-02-17 04:39 EST by Mauro Poggianella CLA
Modified: 2014-03-06 15:39 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mauro Poggianella CLA 2014-02-17 04:39:15 EST 
In the org.eclipse.ui.actions.ActionFactory (line 632) the "LOCK_TOOL_BAR" Action is wrongly defined as "IWorkbenchCommandConstants.HELP_ABOUT", and should be "IWorkbenchCommandConstants.WINDOW_LOCK_TOOLBAR"
Comment 1 Curtis Windatt CLA 2014-02-18 09:47:10 EST 
This is definitely incorrect, but reading over the code, it looks like it should use getCommandId(), and not a direct constant.  The action factory is passed the literal "lockToolBar".  That could probably be replaced with the constant.  Though I'm not 100% sure as the constant is qualified "org.eclipse.ui.window.lockToolBar".

Moving to Platform UI for comment.
Comment 2 Paul Webster CLA 2014-02-20 14:55:54 EST 
Yes, it should be updated to new ActionFactory("lockToolBar", IWorkbenchCommandConstants.WINDOW_LOCK_TOOLBAR) and then the action creation should use getCommandId().

See https://wiki.eclipse.org/Platform_UI/How_to_Contribute

PW
Comment 3 Tobias Baumann CLA 2014-03-02 13:27:51 EST 
Thanks for the linked wiki page and following my first Gerrit patch set:
https://git.eclipse.org/r/#/c/22714/
Comment 5 Paul Webster CLA 2014-03-06 15:39:59 EST 
In 4.4.0.I20140305-2000

PW