Community
Participate
Working Groups
BidiUtils were introduced via bug 383185 At the moment they cover only Text widget: public static void applyBidiProcessing(Text field, String handlingType) Similar to Text widget handling was added to ComboBox via bug 407927 Thus BidiUtils should cover ComboBox as well. public static void applyBidiProcessing(Combo field, String handlingType)
Created attachment 240446 [details] applyBidiProcessing API for Combo Hello Markus, Please find in attachment the applyBidiProcessing API for combo Please note that this patch depends on https://bugs.eclipse.org/bugs/show_bug.cgi?id=407927 Thank you
We will provide an updated patch the same date the change in bug 407927 is committed. At the moment, the idea was simply to set the expectations on the suggested change (really a minor one). We are simply adding a new signature for already present function: public static void applyBidiProcessing(Combo combo, String handlingType) { SegmentListener listener = getSegmentListener(handlingType); if (listener != null) { combo.addSegmentListener(listener); } } Current signature works with Text object, new signature works with Combo object. The importance of this API is in the fact that without it, it won't be possible to leverage new functionality introduced via bug 407927 . Many thanks for your support and help.
I think we both (Moshe and me) pressed the Save button too early :-)). The dependent changes in bug 407927 were already delivered. Thus currently submitted patch is the right one to look at (no additional ones are required).
I'm checking this patch and bug 407927 and will release the API today.
Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d1262d545c169942ed70b824486071ffd11137ca Added the missing @since tag, the missing "." in the Javadoc, the same debugging aids as in applyBidiProcessing(Text, String), and an if-clause in applyTextDirection(Control, String). The latter shouldn't make a difference as of now, but but it could avoid a problem in the future if combo#addSegmentListener(..) is ever implemented on other platforms.
Verified on the 05/03/14 build. Thank you very much Markus for your help.
