Bug 427214 - "Maven > Assign to working set..." menu appears on non-maven project
Summary: "Maven > Assign to working set..." menu appears on non-maven project
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 08:02 EST by Fred Bricon CLA
Modified: 2021-04-19 13:26 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fred Bricon CLA 2014-02-02 08:02:59 EST
"Maven > Assign to working set..." menu appears on non-maven projects as there's no visibility constraint on org.eclipse.m2e.core.ui\plugin.xml :

      <objectContribution
            adaptable="true"
            id="org.eclipse.m2e.assignWorkingSet"
            objectClass="org.eclipse.core.resources.IProject">
         <action
               class="org.eclipse.m2e.core.ui.internal.actions.AssignWorkingSetAction"
               id="org.eclipse.m2e.createWorkingSet"
               label="%action.assignWorkingSet.label"
               menubarPath="org.eclipse.m2e.core.mavenMenu/assignWorkingSet">
         </action>
      </objectContribution>

It should be 

      <objectContribution
            adaptable="true"
            id="org.eclipse.m2e.assignWorkingSet"
            objectClass="org.eclipse.core.resources.IProject">
         <action
               class="org.eclipse.m2e.core.ui.internal.actions.AssignWorkingSetAction"
               id="org.eclipse.m2e.createWorkingSet"
               label="%action.assignWorkingSet.label"
               menubarPath="org.eclipse.m2e.core.mavenMenu/assignWorkingSet">
         </action>
         <visibility>
           <and>
             <objectState name="open" value="true"/>
             <objectState name="nature" value="org.eclipse.m2e.core.maven2Nature"/>
           </and>
         </visibility>
      </objectContribution>
Comment 2 Denis Roy CLA 2021-04-19 13:26:04 EDT
Moved to https://github.com/eclipse-m2e/m2e-core/issues/