Bug 426884 - Java Version 1.8 of project facet java does not exist
Summary: Java Version 1.8 of project facet java does not exist
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major with 2 votes (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords:
: 427445 (view as bug list)
Depends on: 428468
Blocks: 430637 522750
  Show dependency tree
 
Reported: 2014-01-29 08:16 EST by Daniele Cascato CLA
Modified: 2017-09-25 11:11 EDT (History)
18 users (show)

See Also:


Attachments
Screenshot of the error message (19.58 KB, image/png)
2014-01-29 08:16 EST, Daniele Cascato CLA
no flags Details
Patch v1 (4.84 KB, patch)
2014-02-14 16:35 EST, Konstantin Komissarchik CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele Cascato CLA 2014-01-29 08:16:13 EST
Created attachment 239429 [details]
Screenshot of the error message

I have a problem with my maven webapp and jdk 1.8.
I have installed jdk 1.8, the JDT/Eclipse Java 8 Support (BETA) and Eclipse Maven Support (http://download.eclipse.org/technology/m2e/milestones/1.5)
After I changed the java version of my webapp to jdk 1.8 I got following error message when try to update my maven project.
"Could not update project webapp configuration
 Version 1.8 of project facet java does not exist"
Attached a screenshot.
Best regards
D.C
Comment 1 Stephan Herrmann CLA 2014-01-30 11:40:56 EST
(In reply to Daniele Cascato from comment #0)
> "Could not update project webapp configuration
>  Version 1.8 of project facet java does not exist"

Mh, I don't know who should be contributing that project facet.
m2e? WebTools?
Comment 2 Chuck Bridgham CLA 2014-02-04 13:16:44 EST
Hey guys....   I just did a search regarding the java 8 facet...   not that JDT has started supporting Java 8...   we can move this to WTP - I'll move it now.
Comment 3 Stephan Herrmann CLA 2014-02-05 16:21:36 EST
*** Bug 427445 has been marked as a duplicate of this bug. ***
Comment 4 Chuck Bridgham CLA 2014-02-06 13:53:24 EST
Here is the bugzilla for the last time we did this...  No patch attachment though  :(

https://bugs.eclipse.org/bugs/show_bug.cgi?id=298904
Comment 5 Konstantin Komissarchik CLA 2014-02-11 11:56:30 EST
I can take this on.
Comment 6 Konstantin Komissarchik CLA 2014-02-14 16:35:34 EST
Created attachment 239967 [details]
Patch v1

Version 1.8 of Java facet and related changes. Tested with Kepler SR1 with Java 8 support from [1] and JDK 8 b129.

[1] http://dist.springsource.com/snapshot/TOOLS/java8/e43
Comment 7 Konstantin Komissarchik CLA 2014-02-14 16:37:01 EST
I would recommend waiting to push this until JDT has merged their changes.
Comment 8 Fred Bricon CLA 2014-02-24 13:08:13 EST
It'd be nice if a wide(r) audience could test that fix ASAP, as we've been able to test JDT support for Java 8. Any chance we could also access to WTP+Java 8 builds?
Comment 9 Steve Ulrich CLA 2014-03-10 08:29:34 EDT
(In reply to Konstantin Komissarchik from comment #6)
>
> Version 1.8 of Java facet and related changes. Tested with Kepler SR1 with
> Java 8 support from [1] and JDK 8 b129.
> 
> [1] http://dist.springsource.com/snapshot/TOOLS/java8/e43

Doesn't work for me (Kepler SR2/JDK 8 b132, Builds from 20140308 and 20140309). Version 1.8 doesn't show up. I recognized the timestamps of the builds are the same as the official builds. Do the current builds contain your patch, or should I use a specific one?
Comment 10 Steve Ulrich CLA 2014-03-10 12:48:03 EDT
Forget my last comment. I didn't notice that this was part of the WTP, not JDT
Comment 11 Tobias Gierke CLA 2014-03-18 09:22:32 EDT
(In reply to Konstantin Komissarchik from comment #6)

Eager to play with JDK8 I tried the update site but unfortunately the error message does not go away , I'm still not able to select Java version 8 for the facet (Eclipse 4.3 SR2 , JDK8 b132).
Comment 12 Markus Keller CLA 2014-03-18 17:11:35 EDT
Note that the JDT update site from comment 6 is not active any more.

Official update site for Java 8 support on top of Kepler SR2: http://download.eclipse.org/eclipse/updates/4.3-P-builds/
(This does not include any WTP / Faceted Project support)

master (for Luna) also contains Java 8 support now, so the patch from comment 6 can be released if WTP builds depend on I20140318-0830 or later.
Comment 13 Srikanth Sankaran CLA 2014-03-18 21:52:29 EDT
During ECNA, it came up from more than one source that this bug is blocking
adoption and also heard anecdotes of a whole bunch of users migrating to Intellij
on account of that. Thanks for looking into this asap.
Comment 14 Fred Bricon CLA 2014-03-19 00:36:04 EDT
I created this hotbug for kepler sr2 : bug #430637
Comment 15 Cornelius Lilge CLA 2014-03-20 05:17:51 EDT
Can anyone give an ETA for this (either luna or kepler)?

Also: what do I need to do to add this patch to my eclipse? I have zero experience building eclipse components, but I really want to have this...
Comment 16 Chuck Bridgham CLA 2014-03-20 09:41:22 EDT
The WTP I-build today just moved up to this prereq - I anticipate this getting in over the next week.  We'll also discuss the Kepler patch today in our status meeting, and how to release.
Comment 17 Igor Malinin CLA 2014-03-25 17:44:05 EDT
Today's I-build (I20140325-0830) - still no Java 1.8 facet!
Comment 18 Carl Anderson CLA 2014-03-26 11:12:30 EDT
Today's I-build - Java 1.8 facet!

Committed and released to master for WTP 3.6 M7
Comment 19 Cornelius Lilge CLA 2014-03-26 12:04:09 EDT
Good news &  thank you.
Just for info if you don't want to install an I-Build: M7 is scheduled for 2014-05-07.
Comment 20 Fred Bricon CLA 2014-03-26 16:37:59 EDT
Carl, just as an FYI, Konstantin's patch was not using the proper git format so you lost proper commit authorship. http://git.eclipse.org/c/webtools-common/webtools.common.fproj.git/commit/?id=752bbcfe060a55b5a21ee3a844ad9fee633689ac

I dunno how egit works but in CLI, you can "fix" such commits with 

git commit --amend --author="Author Name <email@address.com>" (change last commit's author)
Comment 21 Fred Bricon CLA 2014-03-26 16:43:33 EDT
BTW, I didn't mean to imply you should fix Kostantin's commit. That ship has sailed already. Just a tip for future reference