Bug 426557 - [KeyBindings] Welcome Screen after plugin installation disables shortcuts
Summary: [KeyBindings] Welcome Screen after plugin installation disables shortcuts
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3.1   Edit
Hardware: PC All
: P3 normal with 3 votes (vote)
Target Milestone: 4.16 M1   Edit
Assignee: Rolf Theunissen CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 426550 469468 560805 (view as bug list)
Depends on:
Blocks: 552208 560385
  Show dependency tree
 
Reported: 2014-01-24 05:40 EST by Johannes Dorn CLA
Modified: 2020-04-06 05:37 EDT (History)
15 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Dorn CLA 2014-01-24 05:40:56 EST
Steps to reproduce:

1. Install "Maven Integration for Eclipse (Juno and newer) 1.4" or "Code Recommenders" from the marketplace.
2. Restart
3. Close welcome screen

Some, but not all shortcuts no longer work in the Java Editor. This includes CMD+1 (Quick+Fix)and CMD+D (Delete Line) on Mac, and CTRL+Arrow-key on Linux.

After restarting Eclipse the shortcuts work again.

I assume this occurs when installing a plugin that adds itself to the welcome screen. I've also reproduced this installing the Memory Analyzer plugin from its update site.

Manually opening the welcome screen doesn't result in this behavior.
Installing plugins that do not add itself to the welcome screen does not result in this behavior.

We have encountered this before in Bug 422642 and Bug 426550.
Comment 1 Johannes Dorn CLA 2014-01-24 06:30:27 EST
*** Bug 426550 has been marked as a duplicate of this bug. ***
Comment 2 miro CLA 2017-06-21 08:14:56 EDT
I have just encountered the bug when installing Code Recommenders on Neon.

Restart of the workbench solves the problem.
Comment 3 Mohamed Elbeltagy CLA 2017-10-15 18:43:38 EDT
I had the same issue with the latest Eclipse Oxygen 4.7.1a.

To generate the issue: 
1. Open a new workspace (I tested it by letting Eclipse ask about the workspace every time)
2. Open a Java file and leave the editor open (I tested it using editor open for only one Java file - Workspace has only one Java project, not maven-based, which has only one Java file).
3. Close Eclipse
4. Reopen the same workspace (I tested it by letting Eclipse ask about the workspace every time)

To work around the issue; I did the following:
1. Close the Welcome view.
2. Close open editors.
3. Open the editors again without issues
4. If wanted, can open the Welcome view again which will not cause any trouble.

I was able to, constantly, regenerate the issue according to the previous scenario and work around the issue according to the mentioned steps.

Environment used:
* Eclipse Oxygen 4.7.1a (if it matters, Java EE bundle version 4.7.1 that has been updated to 4.7.1a)
* Windows 7 - 64-Bit
* Oracle JRE 9 (build 9+181)
* If it matters, Java project is using JRE 1.8.0_144 (not JRE 9)
Comment 4 Aleksander Vines CLA 2017-12-10 13:32:06 EST
Thanks for the workaround. I also had this issue now and it is simply not possible to work with it.
Comment 5 Mickael Istria CLA 2018-02-19 06:59:47 EST
@Andreas: should we move this bug to CodeRecommenders bucket?
Comment 6 Andreas Sewe CLA 2018-02-19 07:03:38 EST
(In reply to Mickael Istria from comment #5)
> @Andreas: should we move this bug to CodeRecommenders bucket?

I haven't tried to reproduce myself, but...

(In reply to Johannes Dorn from comment #0)
> I assume this occurs when installing a plugin that adds itself to the
> welcome screen. I've also reproduced this installing the Memory Analyzer
> plugin from its update site.

...if this also occurs when installing MAT, then Code Recommenders is innocent (or as guilty as MAT ;-), and the problem is more likely with the platform.
Comment 7 fabtagon . CLA 2019-12-02 07:30:41 EST
Problem persists with Eclipse-2019-09
Comment 8 Rolf Theunissen CLA 2020-04-04 04:26:45 EDT
*** Bug 560805 has been marked as a duplicate of this bug. ***
Comment 9 Rolf Theunissen CLA 2020-04-04 04:31:45 EDT
Been doing some testing, and it seems that the shortcuts are only broken for the active Java editor. For the text editor the shortcuts remain working, also for the non-active Java editors it works.
The 'active' editor never gets the key bindings back. The workaround is to close the editor and reopen.
Comment 10 Rolf Theunissen CLA 2020-04-04 04:49:01 EDT
The same problem can be reproduced by minimizing the editor area:

1. Open a Java editor
2. Minimize the editor area
3. Restart

The key bindings for 'org.eclipse.ui.textEditorScope' seem not to be active.

The problem is not limited to Java editors, PDE editors suffer the same issue. At least some of the binding tables are not activated.
Comment 11 Rolf Theunissen CLA 2020-04-05 05:25:58 EDT
The area is minimized, when the welcome screen is open when eclipse is started.
When the Area is minimized, it is not visible, therefore it is bound to the limbo shell.
This causes that the editor is constructed under the limbo shell, as a result, the key bindings are only active in the limbo shell and not in the workbench.
Comment 12 Rolf Theunissen CLA 2020-04-05 06:14:05 EDT
*** Bug 469468 has been marked as a duplicate of this bug. ***
Comment 13 Eclipse Genie CLA 2020-04-05 14:52:07 EDT
New Gerrit change created: https://git.eclipse.org/r/160495