Bug 42627 - [Contributions] Actions not shown in UI when registered with the global action handler
Summary: [Contributions] Actions not shown in UI when registered with the global actio...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P5 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2003-09-05 13:37 EDT by Jean-Michel Lemieux CLA
Modified: 2019-11-27 07:26 EST (History)
2 users (show)

See Also:


Attachments
Patch to plugin.xml and plugin.properties (1.80 KB, patch)
2003-09-11 09:34 EDT, Douglas Pollock CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Lemieux CLA 2003-09-05 13:37:34 EDT
3.0 M3

The Synchronize View has actions that appear in the view's tollbar. They have
keybindings to the NEXT, PREVIOUS global handlers. They don't appear in the UI
unless I comment out the code to register them with the keybinding service and
the global handler. Pre-3.0 this was working just fine. I suspect the new
command stuff is to blame...

All other actions, not registered with the service are shown correctly. Because
of this the select next/previous toolbar items in the sync view are not shown.
Comment 1 Chris McLaren CLA 2003-09-09 19:47:45 EDT
doug please look at this one right away.. thanks.
Comment 2 Douglas Pollock CLA 2003-09-10 13:15:42 EDT
from a conversation with jean-michel:
Lines 49, 50, 53 and 54 of NavigateAction (org.eclipse.team.ui) can be commented
out to get the two buttons to appear in the (new) Synchronize view toolbar.  If
those lines aren't commented out, then the buttons do not appear.
Comment 3 Douglas Pollock CLA 2003-09-11 09:34:09 EDT
Created attachment 6079 [details]
Patch to plugin.xml and plugin.properties

The commands weren't defined.
Comment 4 Douglas Pollock CLA 2003-09-11 09:35:49 EDT
I'm not sure if this is a regression in functionality over the old architecture.
 (I just started here a couple of months ago.)  If it is, punt the bug back at
Chris.
Comment 5 Jean-Michel Lemieux CLA 2003-09-11 12:07:35 EDT
Thanks Doug. that worked.

It would probably be nice if something was added to the log when an action is
being ignored for whatever reason. It would help plugin developers track down
problems like this without having to raise a bug :) 

An in this particular case, maybe allow the action to be shown but disable the
keybdings?
Comment 6 Chris McLaren CLA 2003-09-25 13:33:27 EDT
fixed.
Comment 7 Chris McLaren CLA 2003-10-07 16:34:58 EDT
not actually fixed in terms of logging information, i meant 'invalid' as doug 
provided the solution without changing code related to this bug.

that being said, i'm reopening this one to review during m5 to cover the 
logging case.
Comment 8 Chris McLaren CLA 2005-12-12 16:57:35 EST
Reassigning to Platform-UI-Inbox (I left IBM 18 months ago..)
Comment 9 Michael Van Meekeren CLA 2006-04-21 13:56:12 EDT
Moving Dougs bugs
Comment 10 Paul Webster CLA 2007-04-05 19:02:41 EDT
Assigning to component owner
PW
Comment 11 Daniel Rolka CLA 2013-09-25 07:29:18 EDT
The change is connected to Team UI component. I will reassign to the Team inbox

Daniel
Comment 12 Lars Vogel CLA 2019-11-27 07:26:14 EST
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.