Bug 426138 - "and", "or", "xor" keywords are not syntax colored in php editor
Summary: "and", "or", "xor" keywords are not syntax colored in php editor
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 09:59 EST by itay friedman CLA
Modified: 2020-05-14 10:15 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description itay friedman CLA 2014-01-20 09:59:50 EST 
Not sure what should be the desired result.
In my opinion these keywords can remain without syntax coloring, but
looking at /org.eclipse.php.ui/src/org/eclipse/php/internal/ui/editor/highlighter/LineStyleProviderForPhp.java
you can notice that Logical "and", "or", and "xor",
are meant to be syntax colored, same as other keywords.
e.g. line 72: 
fColorTypes.put(PHPRegionTypes.PHP_LOGICAL_AND,
				PreferenceConstants.EDITOR_KEYWORD_COLOR);

this doesn't happen, because they are recognized as PHP_Operateor by the lexer,
which are set to normal color in line 62:
fColorTypes.put(PHPRegionTypes.PHP_OPERATOR,
				PreferenceConstants.EDITOR_NORMAL_COLOR);

If decided that this behaviour doesn't need to be changed, this can be closed as not a bug.