Bug 425777 - CTabFolder renderers use the hard coded values for measuring and drawing
Summary: CTabFolder renderers use the hard coded values for measuring and drawing
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-15 10:29 EST by Daniel Rolka CLA
Modified: 2020-08-18 16:59 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Rolka CLA 2014-01-15 10:29:28 EST
The current implementation of the CTabFolderRenderer class (as well as its Platform UI extended version - CTabRendering) uses plenty of hard coded values that are not clear. It would be perfect to calculate it or at least expose it by some constants
Comment 1 Lars Vogel CLA 2016-09-12 06:27:12 EDT
Noticed that some examples in https://github.com/jeeeyul/eclipse-themes uses rounded corners at the top and "sharp" corners at the bottom. If we adjust a similar change, I think we can reduce the padding. 

Reopening to have a "reminder" bug for this investigation.
Comment 2 Eclipse Genie CLA 2019-12-29 05:18:25 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Mike Marchand CLA 2020-05-08 09:57:21 EDT
Overall, I don't think we should close this bug since this work should still be done at some point.  The CTabRendering implementation is full of hard coded values... not to mention that changing some of the constant values doesn't produce the expected results in many cases.

In my honest opinion, this class suffers from feature bloat and it is not easy to maintain as a result.

Realistically, this is the type of UI area that needs visual documentation to define and align expectations of behavior.
Comment 4 Lars Vogel CLA 2020-05-11 15:53:39 EDT
Please reopen if the problem still persists.
Comment 5 Mickael Istria CLA 2020-08-18 16:59:57 EDT
Still relevant.