Bug 425458 - [api] provide API in connector core to validate repositories
Summary: [api] provide API in connector core to validate repositories
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 enhancement (vote)
Target Milestone: 3.11   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2014-01-10 17:33 EST by Steffen Pingel CLA
Modified: 2014-02-19 19:02 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2014-01-10 17:33:33 EST
The API for validating repository connections that is currently in AbstractRepositorySettingsPage should be moved to the connector core to make it accessible outside of the settings page context.

The implementation should return information about the repository, e.g.:

  RepositoryStatus validate(TaskRepository repository, IProgressMonitor monitor) throws CoreException
  
  class RepositoryStatus {
  
    RepositoryVersion getVersion();
    
  }
Comment 1 Steffen Pingel CLA 2014-01-10 19:02:25 EST
Frank, I pushed a review to https://git.eclipse.org/r/#/c/20529/1 with an initial implementation to demonstrate what I have in mind in terms of generalizing the API and tests. The ValidationTest is fully connector agnostic so it could be run for any connector that implements the API. That way we don't end up duplicating tests but only really need to implement them once.

There are still some pieces missing such as dynamically discovery of the connector kind instead of using the hard coded annotation but it should give you an idea.
Comment 2 Steffen Pingel CLA 2014-01-13 13:32:28 EST
Frank, I'll assign this to you since you already did part of the work. It would be great to merge the relevant parts from review https://git.eclipse.org/r/#/c/19178/ into the review from comment #1.
Comment 3 Steffen Pingel CLA 2014-02-19 19:02:57 EST
Frank, I think this is complete. Please reopen if there is still anything outstanding here.