Community
Participate
Working Groups
webkit1 crashes the main process when a plugin crashes, and webkit2 is the current actively supported version. I have started working on this since I have failed to come up with a solution for https://bugs.eclipse.org/bugs/show_bug.cgi?id=334466 and I have a preliminary patch which I will post shortly. Your feedback and thoughts would be greatly appreciated :)
Preliminary patch: https://git.eclipse.org/r/#/c/20521/
Uploaded the latest patch https://git.eclipse.org/r/#/c/20521/ This patch includes more features ported such as - context menu handling - navigation policy handling - loading pages from local URI's. The current major issue is that when loading HTML by providing as a string through setText if the HTML includes links to CSS files, the files are ignored. Actually the files are loaded but the styling is not applied. I noticed that in the original code the implementation of setText was a bit round about; setText saves the provided HTML and loads a blank page (about:blank) then when the load signal is received the HTML is set using webkit_web_view_load_string. This may have been a work around for the issue above. If anyone has more information on this please let me know.
*** Bug 425614 has been marked as a duplicate of this bug. ***
> The current major issue is that when loading HTML by providing as a string > through setText if the HTML includes links to CSS files, the files are > ignored. Actually the files are loaded but the styling is not applied. > Turns out this was an encoding issue. Webkit expects linked CSS files to be UTF16. I file this bug about it upstream: https://bugs.webkit.org/show_bug.cgi?id=127481
Hello Sami. Using a recent version of webkit1 (2.3.2) with GTK2 (SWT_GTK3=0), I get a crash when first showing the welcome screen (Bug 425614). Does this patch address this issue? Or is this exclusively to support webkit2?
Hi > Hello Sami. Using a recent version of webkit1 (2.3.2) with GTK2 > (SWT_GTK3=0), I get a crash when first showing the welcome screen (Bug > 425614). Maybe you are facing the googletalk-plugin issue: WebKit1 crashes eclipse when googletalk-plugin is installed (Bug 334466). That is what motivated me to work on this. > Does this patch address this issue? Or is this exclusively to > support webkit2? This does not directly address your issue. This bug is to keep track of webkit2 support.
(In reply to Sami Wagiaalla from comment #6) > Hi > > > Hello Sami. Using a recent version of webkit1 (2.3.2) with GTK2 > > (SWT_GTK3=0), I get a crash when first showing the welcome screen (Bug > > 425614). > > Maybe you are facing the googletalk-plugin issue: WebKit1 crashes eclipse > when googletalk-plugin is installed (Bug 334466). That is what motivated me > to work on this. I just checked, I don't have this installed. Good to know though! > > Does this patch address this issue? Or is this exclusively to > > support webkit2? > > This does not directly address your issue. This bug is to keep track of > webkit2 support. I see. I tested your patch anyway to see if by any chance it indirectly addressed the crash but I still got it. So it does seem to be worth treating it as a different bug.
> I see. I tested your patch anyway to see if by any chance it indirectly > addressed the crash but I still got it. So it does seem to be worth treating > it as a different bug. Thanks for testing my patch! I will CC myself on your bug. I will look into it if it is still present with WebKit2
> Turns out this was an encoding issue. Webkit expects linked CSS files to be > UTF16. I file this bug about it upstream: > https://bugs.webkit.org/show_bug.cgi?id=127481 This issue has now been addressed upstream. And I have uploaded a new patch https://git.eclipse.org/r/#/c/20521/ which adds policy decision handling.
The latest patch is up: https://git.eclipse.org/r/#/c/20521/ It contains the following fixes: - Browser back and forward buttons were not working. - Loading progress is now shown properly. - The browser does not navigate to an empty page after showing a help popup.
The latest patch: https://git.eclipse.org/r/#/c/20521/ adds support for adding custom HTTP authentication listeners
The latest patch https://git.eclipse.org/r/#/c/20521/ adds support for setting custom HTTP headers.
Initial port is pushed to master. It's not complete yet but good enough for simple usage or when one has to run on machine with additional browser plugins that might crash webkit 1.x. With webkit 2.x running them out of process this prevents crashing the IDE. Being enabled by SWT_WEBKIT2 env variable only makes it pretty safe change as it would not popup to people that haven't requested it explicitly.
Worth noting: https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001821.html ("Deciding the deprecation path for WebKit1").
(In reply to Grant Gayed from comment #14) > Worth noting: > https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001821.html > ("Deciding the deprecation path for WebKit1"). It is finally stating the obvious for everyone who tried to run webkit1 on latest distros :).
