Bug 424060 - Support advertising/de-advertisting IServiceInfos via OSGi service registry
Summary: Support advertising/de-advertisting IServiceInfos via OSGi service registry
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.discovery (show other bugs)
Version: 3.7.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.8.0   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard: Yes, this is the whiteboard pattern. ;-)
Keywords: noteworthy
Depends on:
Blocks: 424059 426701
  Show dependency tree
 
Reported: 2013-12-14 14:28 EST by Markus Kuppe CLA
Modified: 2014-02-18 02:29 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2013-12-14 14:28:58 EST
The OSGi service registry semantics map 1:1 to ECF's IDiscoveryAdvertiser. Thus, support the use case where an IServiceInfo instance is registered with the OSGi service registry to be advertised by _all_ discovery advertisers. Once unregistered, the IDAs stop advertising the service too.

This has the added benefit, that users of IDiscoveryAdvertisers do not have to care about the life-cycle of IDAs.
Comment 1 Markus Kuppe CLA 2013-12-16 09:54:44 EST
https://git.eclipse.org/r/19861
Comment 2 Markus Kuppe CLA 2013-12-16 10:30:42 EST
Released to master with commit id 695a5cee6021806d7d8a05b106ee7baec3073bf8 [1]

[1] http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/commit/?id=695a5cee6021806d7d8a05b106ee7baec3073bf8
Comment 3 Markus Kuppe CLA 2013-12-16 12:10:21 EST
JmDNS, jSLP and ZooKeeper tests all come in green, marking as fixed. :-)



Btw. ECF discovery additionally could even go beyond announcing IServiceInfos transparently via whiteboard pattern in that regular OSGi services with a marker property (similar to service.exported.interfaces) could transparently be advertised (no need for IServiceInfo at all).
Comment 4 Markus Kuppe CLA 2013-12-16 12:10:42 EST
done
Comment 5 Markus Kuppe CLA 2014-02-18 02:24:55 EST
Noteworhty: "IServiceInfo instances registered with the OSGi service registry will automatically be advertised by ECF discover (if a discovery provider is active). Service Registry de-registration of IServiceInfo also de-advertises the service on the discovery layer"
Comment 6 Markus Kuppe CLA 2014-02-18 02:29:02 EST
(In reply to Markus Kuppe from comment #5)
> Noteworhty: "IServiceInfo instances registered with the OSGi service
> registry will automatically be advertised by ECF discover (if a discovery
> provider is active). Service Registry de-registration of IServiceInfo also
> de-advertises the service on the discovery layer"

Scratch comment #5

Noteworhty: "IServiceInfo instances registered with the OSGi service registry will automatically be advertised by all (active) ECF discovery providers. Conversely Service Registry de-registration of IServiceInfo also de-advertises the service on the discovery layer".