Community
Participate
Working Groups
The current implementation of RSA does not take advantage of newly activated discovery providers. Service endpoints won't be advertised with dynamically started providers.
https://git.eclipse.org/r/19832
(In reply to Markus Kuppe from comment #1) > https://git.eclipse.org/r/19832 A couple of questions and comments. 1) With the IServiceInfoFactory registration via DS...means that DS is required by remote service admin. (serviceInfoFactory.xml). Is that right? I don't have any fundamental objections...but it does mean more requirements for ECF RSA. 2) In AbstractTopologyManager there's member variable: » private final IServiceInfoFactory serviceInfoFactory = new ServiceInfoFactory(); This instance binding is probably undesirable...i.e. should probably use either DS or ServiceTracker so that alternative IServiceInfoFactory implementers could be used. What I was doing previously was setting the priority of ServiceInfoFactory registration to lowest possible...Integer.MIN_INTEGER or something...so that any other IServiceInfoFactory registration would take priority. 3) In the previous code (for accessing the IEndpointDescriptionAdvertiser service) there's doPriveleged block...i.e. IEndpointDescriptionAdvertiser advertiser = AccessController .doPrivileged(new PrivilegedAction<IEndpointDescriptionAdvertiser>() { 78 »
(In reply to Scott Lewis from comment #2) > (In reply to Markus Kuppe from comment #1) This was accidently sent while in mid-edit for the gerrit review. The full comments are on the review itself https://git.eclipse.org/r/19832
please don't spend anymore time on the review. I have substantially reworked it locally (should have marked it WIP, sorry).
https://git.eclipse.org/r/19967 supersedes https://git.eclipse.org/r/19832 (please do not approve!!!)
Dedicated build for this enhancement https://build.ecf-project.org/jenkins/job/C-424059-sdk.feature/ off of branch 424059 (forked from _master_)
The advertiser part has been taken care of. Next org.eclipse.ecf.osgi.services.remoteserviceadmin.EndpointDescriptionLocator is going to be rewritten to use the whiteboard pattern and to be simplyfied (there is no need to deal with specific IDiscoveryLocators _at all_. EDL can simply register an IServiceListener that is automatically notified).
First part (IDiscoveryAdvertiser) has been pushed to master [1]. [1] http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/commit/?id=44b7a5ba09f181b83a071a0e7ddbe5ff89b7436d
Has this been completed (and can be resolved) for ECF 3.8.0? Or should the target be moved to 3.8.1?
Advertisers done, Locators not yet. Thus moving target to 3.8.1
Moving to 3.8.2 target as cannot complete for 3.8.1/Luna.
