Bug 423671 - [About] 'Copy' menu item is always disabled in 'About Dialog'
Summary: [About] 'Copy' menu item is always disabled in 'About Dialog'
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
: 516711 536161 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-10 05:33 EST by Dani Megert CLA
Modified: 2021-10-26 12:50 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2013-12-10 05:33:42 EST
R4.3 and newer. Worked in R4.2.

The 'Copy' menu item is always disabled in 'About Dialog'. After using Ctrl+C it works.
Comment 1 Wojciech Sudol CLA 2013-12-10 07:05:22 EST
I can reproduce it in 4.3.2, but in 4.4 M3 and M4 it works correctly ('copy' is active and does copy selected text).
Comment 2 Dani Megert CLA 2013-12-10 07:18:48 EST
(In reply to Wojciech Sudol from comment #1)
> but in 4.4 M3 and M4 it works correctly ('copy' is active and does copy 
> selected text).

Not for me using Windows 7 and I20131209-2000. Note that if you press Ctrl+C at some point, it will enable the menu.
Comment 3 Wojciech Sudol CLA 2013-12-10 07:29:50 EST
Interesting. The 'copy' item is active when you open the 'about' dialog directly after starting Eclipse instance with fresh workspace. But if a keyboard shortcut (e.g. Ctrl+N) is used before opening the dialog, the item is disabled. Restart does not help.
My OS: Windows 7 x64
Build: I20131209-2000
Comment 4 Dani Megert CLA 2017-05-16 10:23:21 EDT
*** Bug 516711 has been marked as a duplicate of this bug. ***
Comment 5 Andrey Loskutov CLA 2017-05-16 10:41:43 EDT
WidgetMethodHandler for the "copy" method expects the currently focused widget to have "copy()" public method. If we open "About" dialog, focus is always on "close" button, so the handler is disabled. 

What is interesting however, that even if one now selects some text and right clicks inside the StyledText (so the focus is changed), the menu contributions aren't updated!

BUT if one selects a text in the Java editor *before* opening about dialog, the "copy" is enabled and surprisingly works :-).
Comment 6 Dani Megert CLA 2018-06-22 04:32:45 EDT
*** Bug 536161 has been marked as a duplicate of this bug. ***
Comment 7 Eclipse Genie CLA 2020-06-21 17:01:56 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Stephan Wahlbrink CLA 2021-10-26 07:25:11 EDT
The bug is still reproducible in latest integration builds (I20211023-1800 for 2021-12 M2).
Comment 9 Stephan Wahlbrink CLA 2021-10-26 12:50:08 EDT
The WidgetMethodHandler tracks the focus correctly.

The problem is: HandlerServiceHandler.isEnabled() which is called in CommandContributionItem.isEnabled() uses the context (and its handler) of the currently active view part.