Community
Participate
Working Groups
When navigating from a comment to another, enable hovering and popup the comment. In addition, when user actually chooses to hover over popup area, open up an edit dialog on the comment. This feature depends on bug 422673.
That sounds like a great idea. Guy, I believe you mentioned that you were planning to work on this on the last call and showed a first demo of this feature. I'll assign this to you for now but feel free to bounce back to inbox.
Created attachment 238500 [details] Snapshot of the current prototype This snapshot shows the prototype.
Created attachment 238502 [details] Snapshot of the desired transition This snapshot shows what the final windows would look like.
To give a better understanding I have added 2 attachements: Prototype and Expected In Prototype, we can see the actual display as shown in the current prototype. The first dialog is an extension of PopupDialog with a mousetracker. The second one is an extension of FormDialog. The idea is to change it so that it looks and behaves like the second attachment called Expected which is taken from the Eclipsse Java editor. If any of you has some idea and or snippets to emulate the class used for the Expected attachment, please share. Thanks
I agree, it should look like the one in JDT. I can investigate if there is some code in JDT to borrow.
It's implemented by org.eclipse.jdt.internal.ui.text.java.hover.AbstractJavaEditorTextHover and sub-classes but I'm not sure if it can be used outside of a JavaEditor.
Well, it's EPL so we can definitely re-use the implementation in the Reviews Compare editor.
Good point.
Created attachment 239408 [details] CurrentImplementationPopup This the popup as it's implemented. It reuses the Class used by comment hover to keep consistent look.
Created attachment 239409 [details] CurrentImplementationImputDialog This is a snapshot of current input dialog. The edge is as such to allow the user to move it around at his preference. Its location is then persisted from one comment to another.
Anyone feel free to comment.
Will this also allow comments to be deleted? 410123: allow to remove an added comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=410123
The code has been pushed to gerrit : https://git.eclipse.org/r/#/c/23534/7 Please review it. There is a build failure but it's unit test related and doesn't prevent the review to start. I am looking into the failure cause. To answer comment 12, yes it allows to delete a comment. Thanks
To further clarify, the deletion is possible so long that it's a DRAFT.
*** Bug 410123 has been marked as a duplicate of this bug. ***
Hi folks, I haven't had any feedback regarding the push to gerrit: https://git.eclipse.org/r/#/c/23534/ Patch 10 represents the latest of what was demoed Wednesday April 9th. As discussed, we plan to introduce this into Mylyn 3.12. There are 25 files to review, you should get started asap so it can be merged in time for the cutoff date. Thanks.
I have a question about comment replies. When there are multiple comments on a line, does it make any difference which one is selected when replying? Here are some issues I found. The comment navigation doesn't work properly when there are comments on both sides when using compare with (try it with comments on left line 2, right line 6, left line 8). However I think this works better than it does on master. When opening an image file and clicking the next/prev comment buttons, an exception is logged: java.lang.NullPointerException at org.eclipse.mylyn.internal.reviews.ui.compare.ReviewCompareAnnotationSupport.gotoAnnotation(ReviewCompareAnnotationSupport.java:192) at org.eclipse.mylyn.internal.reviews.ui.compare.ReviewItemCompareEditorInput$2.run(ReviewItemCompareEditorInput.java:115) at org.eclipse.jface.action.Action.runWithEvent(Action.java:498) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$6.handleEvent(ActionContributionItem.java:452) Also, when trying to post a comment as anonymous, I get an error dialog with an NPE: java.lang.NullPointerException at org.eclipse.mylyn.internal.reviews.ui.dialogs.CommentInputDialog$1.run(CommentInputDialog.java:274) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) When closing the compare editor, the open comment hover should also be closed. Sometimes the comment hover appears on a different screen than the Eclipse window when the window is maximized on Windows.
The NPE for when hitting next/prev on a binary file has been fixed with the patch set 35. As per the NPE when adding a comment as anonymous, I don't reproduce this. Also note that this is a functionality that was there in the first place.
(In reply to comment #18) > As per the NPE when adding a comment as anonymous, I don't reproduce this. Also > note that this is a functionality that was there in the first place. CommentInputDialog, where the NPE happens, is added with this review. There is even a compilation warning about it (I think the value of isSave or isDiscard could change by the time the job runs).
I have merged the review. As previously mentioned, this needs further code review. I'll create a subtask to ensure we don't forget to do it.
Code review done.
This is blocked by 441710: add tests for editing and deleting a comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=441710
All subtasks have been closed. Thanks very much for the contribution!
*** Bug 379222 has been marked as a duplicate of this bug. ***
