Bug 422674 - [KeyBindings] Quick Switch Editor keybinding (Ctrl+E/Cmd+E) doesn't work when focus is in view at bottom
Summary: [KeyBindings] Quick Switch Editor keybinding (Ctrl+E/Cmd+E) doesn't work when...
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3.1   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 09:57 EST by Jon Schewe CLA
Modified: 2017-02-21 08:00 EST (History)
2 users (show)

See Also:


Attachments
screenshot of plugins (88.90 KB, image/png)
2013-11-29 09:54 EST, Jon Schewe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Schewe CLA 2013-11-27 09:57:41 EST
I like to use the cmd-e binding to switch between files without using the mouse. Unfortunately I can't seem to get this binding to work in the Git Repositories and Git Staging views. cmd-shift-r works, but not cmd-e. I've seen this behavior on both Mac OS and on Linux.
Comment 1 Robin Stocker CLA 2013-11-27 16:48:19 EST
I can not reproduce this on Linux, Eclipse 4.3.1 and EGit nightly (3.2.0.201311211813).

What version of Eclipse and EGit are you using?
Comment 2 Jon Schewe CLA 2013-11-27 17:18:39 EST
Eclipse Standard/SDK

Version: Kepler Service Release 1
Build id: 20130919-0819

EGit: 3.0.3.201309161630-r

I'm using the standard release channels.
Comment 3 Robin Stocker CLA 2013-11-27 17:35:30 EST
Hm, could you try it with a newly-downloaded Eclipse and a new workspace? I'm not sure what EGit would be doing that causes this to break (and what the difference is between this and Open Resource).
Comment 4 Jon Schewe CLA 2013-11-27 17:38:00 EST
I just installed this eclipse in the past month with a new EGit install as well. Is there something newer than what I have available?
Comment 5 Robin Stocker CLA 2013-11-27 17:41:19 EST
You could try if updating to EGit nightly fixes the problem (although I don't know why is should be different regarding this), see the download page: http://eclipse.org/egit/download/

Trying with a clean workspace would also be help, because some things are stored in the .metadata folder of the workspace.
Comment 6 Jon Schewe CLA 2013-11-27 23:39:17 EST
OK, I just tried it on Linux with an empty workspace and open resource works, but ctrl-e doesn't work. I checked and there's no .log file in my .metadata directory either. I was thinking perhaps there would be some errors listed.

Eclipse Java EE IDE for Web Developers.

Version: Kepler Release
Build id: 20130614-0229

When I look in plugins I see 2 entries for EGit, one is 3.0.0.201306101825-r and one is 3.1.0.201310021548-r.

I also notice that ctrl-e doesn't work in the history view either. I tested putting focus on the other views that are typically at the bottom and no ctrl-e there either. Perhaps it's related to the fact that these views are at the bottom by default? I have them moved up with my editors as I want the extra space in these views.
Comment 7 Robin Stocker CLA 2013-11-28 07:59:31 EST
(In reply to Jon Schewe from comment #6)
> I also notice that ctrl-e doesn't work in the history view either. I tested
> putting focus on the other views that are typically at the bottom and no
> ctrl-e there either. Perhaps it's related to the fact that these views are
> at the bottom by default? I have them moved up with my editors as I want the
> extra space in these views.

Ok, so it's not just in EGit's views that the Quick Switch Editor keybinding (Ctrl+E) does not work. I'm reassigning this to Platform UI.

Jon, could you attach some screenshots of when this works and when it doesn't? I think that could be helpful in diagnosing this.
Comment 8 Jon Schewe CLA 2013-11-29 09:54:42 EST
Created attachment 237858 [details]
screenshot of plugins

Since I opened this ticket I have added the stable update site and updated to 3.1.X of EGit (see the screenshot). Now ctrl-e is working for me in Linux. I don't understand what changed, but it appears to be fine for me on Linux. I guess I'll make sure I have the same version at work on Mac and see if it works there as well.
Comment 9 Jon Schewe CLA 2013-11-29 15:07:33 EST
Need some ideas here. It works in my test workspace that was created from scratch. I went back to my other workspace on Linux and ctrl-e didn't work. So I created a new workspace and imported my project and it still doesn't work. Is it possible for something in the project to be messing with the keybindings?
Comment 10 Patrik Suzzi CLA 2017-02-19 18:23:16 EST
Ctrl+E now works from the mentioned views, both under MacOs and in Linux. Closing as worksforme. 

Please, reopen if you can reproduce.
Comment 11 Jon Schewe CLA 2017-02-21 08:00:42 EST
I'm running Eclipse Neon on Linux and ctrl-e still doesn't do anything when I open git staging.