Bug 420616 - Test failure in new NLS service
Summary: Test failure in new NLS service
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2013-10-29 08:37 EDT by Paul Webster CLA
Modified: 2013-10-31 04:59 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2013-10-29 08:37:06 EDT 
Bug 419204 added new NLS service.

In the milestone warmup I build, one of the tests fails: http://download.eclipse.org/eclipse/downloads/drops4/I20131028-2000/testresults/html/org.eclipse.e4.core.tests_linux.gtk.x86_6.0.html

expected:<[Simp]leMessages 1> but was:<[Bund]leMessages 1>

junit.framework.ComparisonFailure: expected:<[Simp]leMessages 1> but was:<[Bund]leMessages 1>
at org.eclipse.e4.core.internal.tests.nls.NLSTest.testSimple(NLSTest.java:47)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:657)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:109)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:80)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:372)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:226)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 1 Dani Megert CLA 2013-10-29 12:14:17 EDT 
Please fix this for M3. Thanks.
Comment 2 Thomas Schindl CLA 2013-10-30 04:31:07 EDT 
The test passes for me locally - does it only fail on linux?
Comment 3 Thomas Schindl CLA 2013-10-30 04:36:45 EDT 
It could have been an upper/lowercase problem? 

I've now fixed the properties file to be upper-case, http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=b21b2c7430d97f5ffd7ac80d8262196784d509b2. It still passes for me locally, maybe some one with Linux can confirm that it works?
Comment 4 Dani Megert CLA 2013-10-30 05:45:35 EDT 
(In reply to Thomas Schindl from comment #2)
> The test passes for me locally - does it only fail on linux?

Yes. You can look at the build results here: http://download.eclipse.org/eclipse/downloads/
Comment 5 Paul Webster CLA 2013-10-30 05:47:20 EDT 
Thanks Tom, that fixed the problem for me.  We can verify in the next I build

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=b21b2c7430d97f5ffd7ac80d8262196784d509b2

PW
Comment 6 Dani Megert CLA 2013-10-31 04:59:40 EDT 
Verified in I20131030-2000.