Community
Participate
Working Groups
The "Name" and "Location" labels should be bottom aligned with their corresponding text fields.
Sebastian do you mean the New Dialog from the Java Classpath variables page?
The whole Eclipse UI never bottom alignes labels with text fields. They are always centered. If we change this we should change it for whole Eclipse. Asking Platform for comments if there are UI guidelines how to aligne labels and text entry fields.
The way you are doing it is pretty much the defacto standard for Eclipse - we generally do not constrain if there is not a strong reason to do so. I would be inclined to not change your dialog.
Preferences Workbench/Linked Resources New... @@@@ The "visual" difference between bottom and center alignment is quite small. The top aligned labels look weird though. @@@@ I think there should be an UI Guideline. Either center or bottom alignment would be fine with me.
We should follow the Eclipse defacto standard and should center labels and entry fields. Tod, may be we should add a sentence to the UI guideline paper. No further action planned in JDT/UI.
A quick investigation revealed several bottom aligned labels. Should I file bugs for them? @@@@ I reopen this bug because you've probably looked at the dialog from comment #1. The dialog I mentioned does belong to Platform/UI.
Regarding filing bugs: I would do so, but Platform/UI should make clear what the default should be. The bug is assigned to JDT/UI this is why I closed it. Moving to platform then.
The inconsistency is due to us never having made a decision one way or the other about this. I will rename the problem report and assign it to Nick who is looking into guidelines now. If you want to point out anything to us please add to this PR rather than creating a pile more.
Regardless of the UI Guidelines outcome; the "top" alignment of the labels in this dialog should be changed to "center" alignment.
Reassigning bugs in component areas that are changing ownership.
Created attachment 36491 [details] fix - dialog resizable now - updated copyright - replaced unneccessary setFont calls w/ Dialog.applyDialogFont - standard margins at bottom/right/top/left and between widgets - proper resize behavior - labels center aligned
Created attachment 36492 [details] pic showing old (top) and new (bottom) look
marking for 3.2 so as not to lose track of this one
Fixed >20060417. Sebastian, the only thing I didn't like about the patch was the change in tab order caused by moving the creation of the variable name and value fields to the bottom of the method. Instead, I maintained the creation order from before and moved the layout code to the bottom. This also allowed me to change the label creation order so that the labels are created just before their corresponding fields (more screen-reader friendly).
Good point, forgot about the Tab-order :|
cc'ing McQ for FYI.
verified on WinXP, N20060425-0010
