Bug 418857 - [About] "About" menu should show product icon
Summary: [About] "About" menu should show product icon
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2013-10-07 14:36 EDT by Mickael Istria CLA
Modified: 2015-08-24 12:42 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2013-10-07 14:36:37 EDT 
The About menu should show the product icon.
Comment 1 Mickael Istria CLA 2013-10-07 14:48:08 EDT 
Although it is easy to tweak the Action to attach the right imageDescriptor to it (ActionFactory, line 87); it seems like the value of the imageDescriptor is not used to compute the image to show in menu.
Most other actions directly re-use the command image (which is static).
Comment 2 Mickael Istria CLA 2013-10-09 13:13:33 EDT 
Suggested fix: https://git.eclipse.org/r/17227
Comment 4 Paul Webster CLA 2013-10-29 10:26:32 EDT 
In 4.4.0.I20131028-2000

PW
Comment 5 Aline Hippold CLA 2015-08-14 15:51:43 EDT 
The windowImages property may contain paths to other plugins. This fix does not handle such paths.
Comment 6 Mickael Istria CLA 2015-08-24 12:42:25 EDT 
@Aline: Please open another bug report for that.