Bug 416927 - Enhance DirectorMojo to support additional repositories in materializing product
Summary: Enhance DirectorMojo to support additional repositories in materializing product
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-10 09:46 EDT by Sriram Seshan CLA
Modified: 2021-05-02 03:01 EDT (History)
4 users (show)

See Also:


Attachments
Patch to add additional IUs and Repositories (2.80 KB, application/octet-stream)
2013-09-10 09:46 EDT, Sriram Seshan CLA
no flags Details
Patch for resolution (2.67 KB, patch)
2013-09-20 10:23 EDT, Sriram Seshan CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sriram Seshan CLA 2013-09-10 09:46:34 EDT
Created attachment 235354 [details]
Patch to add additional IUs and Repositories

Add ability to install additional install units using both the internal and external P2 Director. Additional install units may be required when meta-requirements need to be installed for custom touch points etc.
Comment 1 Tobias Oberlies CLA 2013-09-10 11:22:31 EDT
What is wrong with source=repository [1]. Just make target/repository include what is needed.

The additionalIUs parameter is the same as a meta-requirement, except that meta-requirements also works if someone creates the installation from your p2 repository with a standalone director.

[1] http://www.eclipse.org/tycho/sitedocs/tycho-p2/tycho-p2-director-plugin/materialize-products-mojo.html#source
Comment 2 Sriram Seshan CLA 2013-09-10 12:36:19 EDT
Restricting the external director to a single repository is a little restrictive. Instead of having to make the target repository to include what is needed, additional repository provides more flexibility. Only users who need this will have to use this and as the patch indicates, it does not add a lot of complexity to the code.

The meta-requirements is only one scenario and it is only supported in the external director. We use additionalIUs to provision our product so that the product and the additionally installed units may be upgraded independently. The additionalIUs section will work both for the internal and external director.
Comment 3 Sriram Seshan CLA 2013-09-20 10:23:00 EDT
Created attachment 235666 [details]
Patch for resolution
Comment 4 Tobias Oberlies CLA 2013-10-18 10:17:08 EDT
These additional repositories would behave differently than repositories specified elsewhere in Tycho:
- They don't adhere to the offline mode
- They ignore the mirror and password settings from the Maven settings.xml [1].

These problems are avoided with the current approach. The above limitations may not be a problem for you, but they make things inconsistent and hence more complex to understand. IMHO, consistency is more valuable than the added convenience for the corner cases which involve custom touchpoints.

[1] http://wiki.eclipse.org/Tycho/Target_Platform/Authentication_and_Mirrors
Comment 5 Tobias Oberlies CLA 2013-10-18 10:19:34 EDT
(In reply to Sriram Seshan from comment #2)
> We use additionalIUs to provision our product so that the
> product and the additionally installed units may be upgraded independently.
> The additionalIUs section will work both for the internal and external
> director.

I consider this out of scope for this enhancement request. There is already a separate enhancement request for this: bug 361722.
Comment 6 Mickael Istria CLA 2021-04-08 18:07:57 EDT
Eclipse Tycho is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/tycho/issues/ instead. If this issue is relevant to you, your action is required.
0. Verify this issue is still happening with latest Tycho 2.4.0-SNAPSHOT
  if issue has disappeared, please change status of this issue to "CLOSED WORKFORME" with some details about your testing environment and how you did verify the issue; and you're done
  if issue is still present when latest release:
* Create a new issue at https://github.com/eclipse/tycho/issues/
  ** Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  ** In the GitHub description, start with a link to this bugzilla ticket
  ** Optionally add new content to the description if it can helps towards resolution
  ** Submit GitHub issue
* Update bugzilla ticket
  ** Add to "See also" property (up right column) the link to the newly created GitHub issue
  ** Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  ** Set status as CLOSED MOVED
  ** Submit

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for Tycho will be archived and made read-only.