Community
Participate
Working Groups
N20130825-2000. http://download.eclipse.org/eclipse/downloads/drops4/N20130825-2000/testresults/html/org.eclipse.core.tests.runtime_linux.gtk.x86_6.0.html 1.0 junit.framework.AssertionFailedError: 1.0 at org.eclipse.core.tests.runtime.jobs.DeadlockDetectionTest.testThreeLocks(DeadlockDetectionTest.java:169) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:655) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:109) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:80) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:372) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:226) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) at org.eclipse.core.launcher.Main.main(Main.java:34)
Could not reproduce and haven't seen this failure before. The test intentionally creates a deadlock between three ILocks, and then checks that our deadlock detection code resolves it. This failure implies it failed to resolve the deadlock.
(In reply to comment #1) > This failure implies it failed to resolve the deadlock. I think that's not entirely true. In this test deadlock can be resloved correctly many times and still the test can fail if threads are not killed successfully. It's not reproducible on demand, but it could happen if RandomTestRunnable.alive was cached and the result of kill was not seen by the thread. You can reproduce the failure by commenting out kill(allRunnables) which would simulate unsuccessful killing. Wouldn't RandomTestRunnable.alive deserve to be volatile? In fact, we could tell if deadlock was resolved or not based on the console output, but at the moment it's impossible to tell which log entry belongs to which test. We could add test name to RandomTestRunnable to get more descriptive logs. Adding getName() in DeadlockDetectionTest.createRunnables(..) is sufficient.
(In reply to comment #1) > Could not reproduce and haven't seen this failure before. Not exactly that one, but other DeadlockDetectionTest tests, see bug 51538 comment 0.
DeadlockDetectionTest.testVeryComplex failed in N20131120-2000: 1.0 junit.framework.AssertionFailedError: 1.0 at org.eclipse.core.tests.runtime.jobs.DeadlockDetectionTest.testVeryComplex(DeadlockDetectionTest.java:974) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:657) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:109) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:80) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:372) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:226) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) at org.eclipse.core.launcher.Main.main(Main.java:34)
N20131127-2000: junit.framework.AssertionFailedError: 1.0 at org.eclipse.core.tests.runtime.jobs.DeadlockDetectionTest.testVeryComplex(DeadlockDetectionTest.java:974) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:657) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:109) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:80) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:372) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:226) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426) at org.eclipse.core.launcher.Main.main(Main.java:34)
I pushed a change to Gerrit that should help to diagnose the cause of these failures: https://git.eclipse.org/r/#/c/20717/
(In reply to Szymon Ptaszkiewicz from comment #6) > I pushed a change to Gerrit that should help to diagnose the cause of these > failures: > > https://git.eclipse.org/r/#/c/20717/ Pushed: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=74f101a07c12cac26ce02a9039b23ba59db8faa3
These tests have not failed for quite some time. Closing as WORKSFORME, but please reopen if you see it again.
