Bug 415278 - change id not shown correctly in task list (shows [mylyn%2Fo] instead)
Summary: change id not shown correctly in task list (shows [mylyn%2Fo] instead)
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 2.0.1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 395059
  Show dependency tree
 
Reported: 2013-08-17 05:29 EDT by Steffen Pingel CLA
Modified: 2013-08-22 10:22 EDT (History)
0 users

See Also:

Attachments
task list (24.84 KB, image/png)
2013-08-17 05:31 EDT, Steffen Pingel CLA 		no flags Details
mylyn/context/zip (9.75 KB, application/octet-stream)
2013-08-20 04:58 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2013-08-17 05:29:14 EDT 
When reviews on Gerrit 2.6 (Eclipse.org) are synchronized the change ID in the task list isn't always shown correctly (see screenshot). If I explicitly synchronize a task that shows [mylyn%2Fo] it shows the expected summary.
Comment 1 Steffen Pingel CLA 2013-08-17 05:31:25 EDT 
Created attachment 234508 [details]
task list

I suspect this is related to updating from full vs. partial task data.
Comment 2 Tomasz Zarna CLA 2013-08-19 12:12:49 EDT 
(In reply to comment #1)
> I suspect this is related to updating from full vs. partial task data.

Yup, and to the fact that in Gerrit 2.6 the "id" field changed to the "project~branch~change_id" triplet.

Review: https://git.eclipse.org/r/15613
Comment 3 Tomasz Zarna CLA 2013-08-20 04:58:36 EDT 
Fixed in fc24302e7c9fdf05d233f36e55a7bb9e2093df10
Comment 4 Tomasz Zarna CLA 2013-08-20 04:58:47 EDT 
Created attachment 234564 [details]
mylyn/context/zip
Comment 5 Miles Parker CLA 2013-08-21 13:55:07 EDT 
Wait...are we *sure* this is an inocous change for pre-2.6 data? This is what is useed to look up existing model reivew data as well. I'm concerned about regressions here..
Comment 6 Tomasz Zarna CLA 2013-08-22 10:22:24 EDT 
The "project~branch~change_id" triplet has been introduced in 2.6 and '~' is not allowed as part of a SHA1, so the check from https://git.eclipse.org/r/#/c/15613/2/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/GerritTaskDataHandler.java should only affect 2.6+ changeIds. I think the change is safe.