Bug 415101 - Markdown: inline images with an empty alt text are not rendered
Summary: Markdown: inline images with an empty alt text are not rendered
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 1.8   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Stefan Seelmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2013-08-14 15:33 EDT by Robert Munteanu CLA
Modified: 2013-10-27 16:11 EDT (History)
3 users (show)

See Also:

Attachments
Screenshot of how the code snippet is rendered (14.75 KB, image/png)
2013-08-14 15:34 EDT, Robert Munteanu CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2013-08-14 15:33:05 EDT 
Consider the following markdown file

bc.. 
	![](images/Time-tracking-action.png)
![](images/Time-tracking-action.png)

	![Alt text](images/Time-tracking-action.png)
![Alt text](images/Time-tracking-action.png)

p. Only the second block is rendered, which is incorrect, since the alt attribute text is not required to be empty.
Comment 1 Robert Munteanu CLA 2013-08-14 15:34:13 EDT 
Created attachment 234428 [details]
Screenshot of how the code snippet is rendered
Comment 2 Stefan Seelmann CLA 2013-08-16 17:14:18 EDT 
Thanks Robert for the bug report. I agree that this is not the correct behaviour, thought that this is not defined by the spec, but other implementations accect an empty alt text.

I uploaded a review request: https://git.eclipse.org/r/#/c/15558/

Beside the main issue (empty alt text in images) now the parser also accepts an empty title. Additional it also accepts empty link text for links, this is not very useful but compatible to other Markdown implementations. Fixed for both inline and reference style images and links.
Comment 3 Steffen Pingel CLA 2013-10-14 23:38:45 EDT 
David, are you planning to merge the change? We are planning to submit the IP log tomorrow so it would have to be in master by then.
Comment 4 David Green CLA 2013-10-25 19:08:17 EDT 
Sorry I missed the cut-off for the release.  I've merged the change now.

Thanks for the contribution Stefan.