Bug 414837 - remove usage of WorkbenchPage.getEditors() from FocusOutlineAction
Summary: remove usage of WorkbenchPage.getEditors() from FocusOutlineAction
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: 3.9.1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: sprint=7;effort=1;
Keywords: contributed
Depends on:
Blocks: 407422
  Show dependency tree
 
Reported: 2013-08-11 23:55 EDT by Steffen Pingel CLA
Modified: 2013-09-17 08:14 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2013-08-11 23:55:43 EDT 
Remove usage of the deprecated platform API WorkbenchPage.getEditors() from FocusOutlineAction to avoid triggering a resource leak in platform described on bug 407422.

WorkbenchPage.getEditors() line: 2262	
FocusOutlineAction.getViewers() line: 87	
FocusOutlineAction(AbstractFocusViewAction).valueChanged(IAction, boolean, boolean) line: 297	
FocusOutlineAction(AbstractFocusViewAction).update(boolean) line: 275	
AbstractFocusViewAction$1.contextChanged(ContextChangeEvent) line: 148	
InteractionContextManager$4.run() line: 464	
SafeRunner.run(ISafeRunnable) line: 42	
InteractionContextManager.deactivateContext(String) line: 454	
TaskActivityMonitor$2.taskDeactivated(ITask) line: 80	
TaskActivityManager.deactivateTask(ITask) line: 518	
TaskListCellModifier.toggleTaskActivation(TreeItem, MouseEvent) line: 128	
TaskListView$11.mouseUp(MouseEvent) line: 898
Comment 1 Tomasz Zarna CLA 2013-08-28 14:01:34 EDT 
Review:  https://git.eclipse.org/r/15942
Comment 2 Steffen Pingel CLA 2013-09-04 06:10:59 EDT 
Thanks very much for the contribution! Shawn, I already merged the change but if you have a minute it'd be great if you could take a look. I actually think this is worth back porting.
Comment 3 Steffen Pingel CLA 2013-09-17 08:14:53 EDT 
I backported the fix to the 3.9.x branch. Thanks very much for the contribution!