Bug 414611 - [Contributions] Toolbar order is not restored after restart (org.eclipse.ui.menus toolbar)
Summary: [Contributions] Toolbar order is not restored after restart (org.eclipse.ui.m...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 438765 569015 (view as bug list)
Depends on:
Blocks: 414612
  Show dependency tree
 
Reported: 2013-08-07 16:51 EDT by Robin Stocker CLA
Modified: 2020-11-23 13:43 EST (History)
4 users (show)

See Also:

Attachments
plugin with toolbar showing the problem (2.89 KB, application/zip)
2013-08-07 16:51 EDT, Robin Stocker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Stocker CLA 2013-08-07 16:51:05 EDT 
Created attachment 234171 [details]
plugin with toolbar showing the problem

The position of a toolbar defined using org.eclipse.ui.menus (under main toolbar) is not persisted/restored correctly - after a restart, the position is reset.

1. Import the attached example plugin
2. Run it as an application with a new workspace
3. Notice the toolbar with a single button with a [+] icon
4. Move this toolbar to another position (e.g. 1 to the right)
5. Exit the application
6. Run it again with the same workspace

Expected: The position is correctly restored
Actual: The position is the same as in step 3
Comment 1 Robin Stocker CLA 2013-08-12 14:50:52 EDT 
I guess nobody has migrated away from the deprecated actionSets extension point yet? Could this be fixed for 4.3.1?
Comment 2 Paul Webster CLA 2013-08-12 15:11:16 EDT 
(In reply to comment #1)
> I guess nobody has migrated away from the deprecated actionSets extension
> point yet?

Half of contributors use commands, and half still use actionSets.

> Could this be fixed for 4.3.1?

Probably not.  My guess is it's related to the fact the ContributionRecords are removed on the disposal of the MMenu as they're re-applied on startup (similar to the IMenuService populateContributionManager(*)/releaseContributions(*))

PW
Comment 3 Rolf Theunissen CLA 2019-07-22 16:36:15 EDT 
*** Bug 438765 has been marked as a duplicate of this bug. ***
Comment 4 Rolf Theunissen CLA 2019-07-22 16:43:35 EDT 
Bug 459231 is more or less the exact opposite of this bug, toolbars are not moved to their original position on the reset of a perspective.
Comment 5 Rolf Theunissen CLA 2020-11-23 13:43:48 EST 
*** Bug 569015 has been marked as a duplicate of this bug. ***