Bug 414461 - RichTextAttributeEditor warning when refreshing/opening gerrit task
Summary: RichTextAttributeEditor warning when refreshing/opening gerrit task
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-06 03:28 EDT by Thomas Ehrnhoefer CLA
Modified: 2014-03-13 10:28 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2013-08-06 03:28:25 EDT
Got this in the error log when I opened a review task and synchronized it:
@Expected an instance of RichTextAttributeEditor, got "<null>"@ 

Since I have no clue what it means, I assume this message should be either not shown or with more information (as other users will probably have the same trouble figuring out what's going on).

Coult be related to bug 414460
Comment 1 Tomasz Zarna CLA 2013-08-13 07:30:12 EDT
(In reply to comment #0)
> Coult be related to bug 414460

I've just seen it without any accompanying NPE, so I don't think they are related. I got this after opening a review, no syncing.
Comment 2 Miles Parker CLA 2013-08-13 14:30:09 EDT
Have *no* idea what's happening here. I think the only rich attribute editor we have is for comment (NEW_COMMENT).. But what might have changed to affect that?
Comment 3 Sam Davis CLA 2013-08-16 12:20:07 EDT
Should be easy to debug if reproducible: set a breakpoint at TaskEditorRichTextPart:108.
Comment 4 Miles Parker CLA 2013-08-16 15:51:48 EDT
On https://git.eclipse.org/r/#/c/15004/8, Tomek reported:

(In reply to comment #21)
> Patch Set 7:
> * Now I can reproduce https://bugs.eclipse.org/bugs/show_bug.cgi?id=414461 quite
> reliably, got 5 warnings in a row

I still can't get that working. Perhaps it is platform specific. I'll fire up my Windows virtual box, but perhaps you could also check whether https://git.eclipse.org/r/#/c/15004/8 ahs any impact.
Comment 5 Miles Parker CLA 2013-08-16 15:52:41 EDT
(In reply to comment #4)
> I still can't get that working. Perhaps it is platform specific. I'll fire up my
> Windows virtual box, but perhaps you could also check whether
> https://git.eclipse.org/r/#/c/15004/8 ahs any impact.

I guess I should say "I still can't get that *not* working". :D
Comment 6 Miles Parker CLA 2013-08-16 16:14:13 EDT
(In reply to comment #4)
> On https://git.eclipse.org/r/#/c/15004/8, Tomek reported:

Correection: That was on https://git.eclipse.org/r/#/c/15004/7 -- it's just possible that the latest patch 8 actually fixs this issue but I'm not sure.

I'm unable to reproduce this on Windows either. So I'm a bit flummoxed. Could someone (Tomek?) set a stack trace and do a little more investigation when this occurs?
Comment 7 Tomasz Zarna CLA 2013-08-16 17:33:04 EDT
(In reply to comment #6)
> Could someone (Tomek?) set a stack trace and do a little more investigation
> when this occurs?

Sure, I'll take a look on Monday.
Comment 8 Tomasz Zarna CLA 2013-08-19 06:58:32 EDT
The warning is logged in @org.eclipse.mylyn.internal.tasks.ui.editors.TaskEditorRichTextPart.createControl(Composite, FormToolkit)@ [1]. In this particular case, apparently, @org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPart.createAttributeEditor(TaskAttribute)@ [2] returned @null@ for the given non-null (already checked in @TaskEditorRichTextPart.createControl@) attribute, so @attribute.getMetaData().getType()@ must have been @null@.

In https://git.eclipse.org/r/15597 I modified the warning logged so next time it happens we should get a stack trace.

[1] https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/tree/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorRichTextPart.java#n94
[2] https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/tree/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPart.java#n61
Comment 9 Tomasz Zarna CLA 2014-03-13 05:32:44 EDT
Thomas, has it happen again to you (any chance for the stack trace from comment 8)? I haven't seen it for a while.
Comment 10 Thomas Ehrnhoefer CLA 2014-03-13 10:28:22 EDT
nope, haven't seen it anymore. thanks for asking Tomek!
Comment 11 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn