Community
Participate
Working Groups
I think it would be useful if the JFace test would be contained in their own plug-in. Currently they are contained in org.eclipse.ui.tests and it looks to me that the JFace unit test in some cases also test platform code. I suggest to move the tests to org.eclipse.jface.tests. Let me know if you think if that is a good idea, if yes, we try to provide a Gerrit review request for it.
I'm not sure why it's this way now, but aside from logically breaking them up I don't see much benefit at this time. o.e.ui.tests has moved up to java 1.5, so it can handle the new jface. PW
If we had tests only for JFace we could include these tests into the maven build of the jface plug-in.
(In reply to Paul Webster from comment #1) > I'm not sure why it's this way now, but aside from logically breaking them > up I don't see much benefit at this time. o.e.ui.tests has moved up to java > 1.5, so it can handle the new jface. > > PW We plan again a GSoC for JFace generics and it would be helpful if the student can work in isolation of the other tests. WE also plan to upgrade the JFace Viewer tests and to move the tests to JUnit 4.
Jeanderson, can you prepare a Gerrit review?
(In reply to Lars Vogel from comment #4) > Jeanderson, can you prepare a Gerrit review? Hi Lars, To start working on this, could you confirm some information? Plugin id: org.eclipse.jface.tests Plugin name: JFace Tests Target Platform: >= 3.5 Version: 3.9.0.qualifier (keep Version from org.eclipse.ui.tests?) Execution Environmet: JavaSE-1.6 - No activator. Activate when one of its classes is loaded - Singleton plug-in - No contributions to the UI Because JFace Tests belong to org.eclipse.ui.tests, I assume it has some dependencies. Should we move them to the new plug-in too or are we going to modify the test suite?
This seems like a lot of work for something that is currently working. You'd have to provide a test.xml for the new plugin, plus make sure our automated tests run them (somewhere in the aggregator). PW
(In reply to Paul Webster from comment #6) > This seems like a lot of work for something that is currently working. > > You'd have to provide a test.xml for the new plugin, plus make sure our > automated tests run them (somewhere in the aggregator). > > PW Thanks Paul, I will look for resources about Eclipse tests to have a better understanding. If you already have something, I appreciate if you could share with me. Thanks in advance.
Our automated test framework is described in: https://wiki.eclipse.org/Platform-releng/Automated_Testing https://wiki.eclipse.org/Platform-releng/Eclipse_Test_Framework PW
(In reply to Paul Webster from comment #6) > This seems like a lot of work for something that is currently working. > > You'd have to provide a test.xml for the new plugin, plus make sure our > automated tests run them (somewhere in the aggregator). > > PW I want to understand our test infrastructure. This is a good place to get to know it. Also I want to migrate to use JUnit4 und Mockito at a later stage and splitting parts of the tests out, will help with the change. I plan that Jeanderson and I do the majority of the work, so you should not be concerned with to much additional work for you. He may only have to ping you for the batch integration.
(In reply to Paul Webster from comment #8) > Our automated test framework is described in: > https://wiki.eclipse.org/Platform-releng/Automated_Testing > https://wiki.eclipse.org/Platform-releng/Eclipse_Test_Framework > > PW Thanks for the references Paul, they were very helpful to understand how to test things on Eclipse. By the way, I was running the JFace Test suite on my computer and I got 6 errors and 1 failure from a total of 970 test cases. Failed tests are: [1 Failure] - testForceModeText [1 Error] - testSetTitleImageEarly [4 Errors] - org.eclipse.jface.tests.images.ResourceManagerTest [1 Error] - testFileImageDescriptorWorkbench Are they really failing or could it be a problem with my setup? Windows 8.1 64bits Version: Luna (4.4) Build id: I20140306-1200 Do you get the same errors too Lars/Paul? After figuring this issue out I could have more confidence to start migrating JFace tests. JBC
(In reply to Jeanderson Candido from comment #10) > Thanks for the references Paul, they were very helpful to understand how to > test things on Eclipse. > > By the way, I was running the JFace Test suite on my computer and I got 6 > errors and 1 failure from a total of 970 test cases. Failed tests are: > > [1 Failure] - testForceModeText > [1 Error] - testSetTitleImageEarly > [4 Errors] - org.eclipse.jface.tests.images.ResourceManagerTest > [1 Error] - testFileImageDescriptorWorkbench > > Are they really failing or could it be a problem with my setup? The tests all run clean for me, when run from the JFace launch config. Or are you trying to run them with the automated test framework? PW
(In reply to Paul Webster from comment #11) > (In reply to Jeanderson Candido from comment #10) > > Thanks for the references Paul, they were very helpful to understand how to > > test things on Eclipse. > > > > By the way, I was running the JFace Test suite on my computer and I got 6 > > errors and 1 failure from a total of 970 test cases. Failed tests are: > > > > [1 Failure] - testForceModeText > > [1 Error] - testSetTitleImageEarly > > [4 Errors] - org.eclipse.jface.tests.images.ResourceManagerTest > > [1 Error] - testFileImageDescriptorWorkbench > > > > Are they really failing or could it be a problem with my setup? > > The tests all run clean for me, when run from the JFace launch config. Or > are you trying to run them with the automated test framework? > > > PW Hi everyone. I was busy an unable to follow up this issue but now I'm working on it again. Paul, I remember I was running the JFace tests directly from the test suite but running from the launch configuration file works as smoothly as expected. Now I feel comfortable to start this migration. Any questions and concerns I will post here. Thanks for the assistance guys.
(In reply to Paul Webster from comment #6) > This seems like a lot of work for something that is currently working. +1. And definitely not something we'll touch for Luna (4.4) at this point.
(In reply to Dani Megert from comment #13) > (In reply to Paul Webster from comment #6) > > This seems like a lot of work for something that is currently working. > > +1. And definitely not something we'll touch for Luna (4.4) at this point. I thought we can still work on components which are not part of the Luna SDK delivery, e.g. demos, snippets unit tests. At least a wanted to update a few demos and snippets to the latest and great Luna API and cleanup some tests.
(In reply to Lars Vogel from comment #14) > (In reply to Dani Megert from comment #13) > > (In reply to Paul Webster from comment #6) > > > This seems like a lot of work for something that is currently working. > > > > +1. And definitely not something we'll touch for Luna (4.4) at this point. > > I thought we can still work on components which are not part of the Luna SDK > delivery, e.g. demos, snippets unit tests. At least a wanted to update a few > demos and snippets to the latest and great Luna API and cleanup some tests. In principle yes. But it should be important / necessary for Luna. Restructuring the tests will for sure cause ripples and/or work for the releng team and that is a no go.
(In reply to Dani Megert from comment #15) > In principle yes. But it should be important / necessary for Luna. > Restructuring the tests will for sure cause ripples and/or work for the > releng team and that is a no go. Thanks for the clarification, makes sense.
Marking as wontfix, no plans to work on this in the near future.
